OTF-2326 push updates for greater than #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenbaldwin
commented
Dec 11, 2024
| return ROWS_MIGHT_MATCH; | ||
| } | ||
|
|
||
| if (checkLowerToUpperBounds(ref, ref2, id, id2, cmp -> cmp > 0)) { |
There was a problem hiding this comment.
when data is equal the lower to upper bound checks return that rows cannot match when they can, removing checks. I have updated my test bteqs for this. These impact data pruning and not file pruning
jenbaldwin
commented
Dec 11, 2024
| @@ -329,16 +329,16 @@ public <T> Boolean gtEq(BoundReference<T> ref, BoundReference<T> ref2) { | |||
| int pos = Accessors.toPosition(ref.accessor()); | |||
| int pos2 = Accessors.toPosition(ref2.accessor()); | |||
| ByteBuffer upperBound = stats.get(pos).upperBound(); | |||
| ByteBuffer upperBound2 = stats.get(pos2).upperBound(); | |||
There was a problem hiding this comment.
correction specific to greater than or equals
added 2 commits
December 12, 2024 06:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expanded my test case bteqs with equals and found a few of the checks could result in no data being returned.