fix(tabs): dialog中的tabs默认选中样式不正确 #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chensid
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
|
Nov-19-2024.18-55-17.mp4应用这个PR的改动 看起来是这个效果 和打开issue描述的问题的效果类似 你复现的效果是修改前后有差异吗？@chensid |
uyarn
approved these changes
Nov 20, 2024
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
[tabs] dialog中的tabs默认选中样式不正确 #4692
💡 需求背景和解决方案
背景：
dialog 设置destroy-on-close属性后，子组件getBoundingClientRect方法获取不正确。
方案：
useResizeObserver中的debounce的wait值设置为35，略大于2 × 16.67ms ≈ 33.34ms
📝 更新日志
fix(tabs): dialog中的tabs默认选中样式不正确
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单