Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix page shaking when dialog and drawer show #4671

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Oct 21, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

此前计算滚动条的方式是基于浏览器默认宽度,定制滚动条的场景会失效,修改计算滚动条的方式,相关PR如下

📝 更新日志

  • fix(Drawer): 修复打开 drawer 时页面抖动的问题

  • fix(Dialog): 修复打开 dialog 时页面抖动的问题 @RSS1102

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

完成

@uyarn uyarn merged commit ade400c into develop Oct 26, 2024
9 checks passed
@uyarn uyarn deleted the fix/page-shaking branch October 26, 2024 16:14
@github-actions github-actions bot mentioned this pull request Oct 27, 2024
16 tasks
@getive
Copy link

getive commented Nov 16, 2024

还是有问题,官网Dialog文档页点按钮显示对话框时,右边还是有抖动。

@uyarn
Copy link
Collaborator Author

uyarn commented Nov 17, 2024

还是有问题,官网Dialog文档页点按钮显示对话框时,右边还是有抖动。

官网的往下的一些例子是因为头部的样式是脱离文档流的一些实现导致的,这个是已知的站点的呈现问题; 实际效果最顶部的 live demo为准,可以在实际项目中验证下的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants