feat(dropdownmenu): 新增DropdownMenu组件 #503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
anlyyao
reviewed
Sep 19, 2024
| keys, | ||
| } = useDefaultProps<DropdownItemProps>(props, dropdownItemDefaultProps); | ||
| const { classPrefix } = useConfig(); | ||
| const itemClass = `${classPrefix}-dropdown-item`; |
| import uniqueId from 'lodash/uniqueId'; | ||
| import React, { FC, useCallback, useContext, useEffect, useMemo, useRef, useState } from 'react'; | ||
| import { CaretDownSmallIcon, CaretUpSmallIcon } from 'tdesign-icons-react'; | ||
| import { Button, Checkbox, Popup, Radio, RadioGroup } from 'tdesign-mobile-react'; |
| @@ -0,0 +1,66 @@ | |||
| import cx from 'classnames'; | |||
| import React, { ComponentProps, FC, forwardRef, useImperativeHandle, useState } from 'react'; | |||
| import { StyledProps } from 'tdesign-mobile-react/common'; | |||
| useDefaultProps<DropdownMenuProps>(props, dropdownMenuDefaultProps); | ||
|
|
||
| const { classPrefix } = useConfig(); | ||
| const name = `${classPrefix}-dropdown-menu`; |
| @@ -0,0 +1,66 @@ | |||
| import cx from 'classnames'; | |||
| import React, { ComponentProps, FC, forwardRef, useImperativeHandle, useState } from 'react'; | |||
There was a problem hiding this comment.
import type { FC } from "react"
类型建议这样引入
anlyyao
reviewed
Sep 19, 2024
|
|
||
| {{ customized }} | ||
|
|
||
|
|
There was a problem hiding this comment.
以上内容应该存放在 tdeisgn-common 子仓库
|
|
||
| {{ customized }} | ||
|
|
||
|
|
| import _DropdownMenu from './DropdownMenu'; | ||
|
|
||
| import './style'; | ||
|
|
There was a problem hiding this comment.
从./DropdownMenu， ./DropdownItem 模块中导出DropdownMenuProps 和DropdownItemProps 这两个类型定义
HaixingOoO
reviewed
Sep 20, 2024
| [keys, inputOptions], | ||
| ); | ||
|
|
||
| const [id] = useState(uniqueId()); |
There was a problem hiding this comment.
用ref
const idRef = useRef(null)
if(!idRef.current){
idRef.current = uniqueId()
}
HaixingOoO
reviewed
Sep 20, 2024
| : {} | ||
| } | ||
| > | ||
| {props.children ? ( |
There was a problem hiding this comment.
直接使用children就好，props.这个可以去掉，统一使用解构的值
HaixingOoO
reviewed
Sep 20, 2024
| )} | ||
| </div> | ||
|
|
||
| {footer ? footer : null} |
There was a problem hiding this comment.
TNode类型的使用parseTNode来渲染
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
fix #392
💡 需求背景和解决方案
📝 更新日志
feat(DropdownMenu): 新增
DropdownMenu组件本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单