Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【CheckBox组件升级】任务单 #459

Closed
5 tasks
Tracked by #389
anlyyao opened this issue Aug 16, 2024 · 2 comments · Fixed by #504
Closed
5 tasks
Tracked by #389

【CheckBox组件升级】任务单 #459

anlyyao opened this issue Aug 16, 2024 · 2 comments · Fixed by #504
Labels
issueshoot 代码共建平台 middle middle level of difficulties

Comments

@anlyyao
Copy link
Collaborator

anlyyao commented Aug 16, 2024 •
edited by github-actions bot
Loading

我们最终的目标是希望 Mobile Vue 和 Mobile React可以共用一套样式文件、一套示例文档。目前 Mobile Vue 端已发布Stable版本，因此在做组件升级时，我们需要和 Mobile Vue端的同名组件保持一样的 DOM结构，以复用一套样式，组件示例文件命名也应和 Mobile Vue 端命名保持一致，以复用一套示例文档。

开发指引

mobile react：组件升级指引

任务清单

  • API功能对齐Mobile Vue端
  • DOM 结构对齐Mobile Vue端
  • 改用 V2文件夹下样式
  • 官网示例代码&&演示示例对齐Mobile Vue端
  • 组件/ 组件示例文件后缀使用 tsx

相关 issues

激励

参与共建的开发者，将可以获得 TDesign 周边（贴纸、鼠标垫、工卡套等）；

成为核心贡献者，将会拥有 TDesign 专属头像。

IssueShoot

  • 预估时长: 5
  • 期望完成时间: 2024-08-26 00:00:00 +0000 UTC
  • 开发难度: 中
  • 参与人数: 1
  • 需求对接人: anlyyao
  • 验收标准: 实现期望改造效果，提 PR 并通过验收无误
  • 备注: 最终激励以实际提交 pull request 并合并为准

IssueShoot

  • 预估时长: 3
  • 期望完成时间: 2024-08-23 00:00:00 +0000 UTC
  • 开发难度: 中
  • 参与人数: 1
  • 需求对接人: anlyyao
  • 验收标准: 实现期望改造效果，提 PR 并通过验收无误
  • 备注: 最终激励以实际提交 pull request 并合并为准
@anlyyao anlyyao mentioned this issue Aug 16, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

👋 @anlyyao，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@anlyyao anlyyao changed the title CheckBox 【CheckBox组件升级】任务单 Aug 16, 2024
@anlyyao anlyyao added issueshoot 代码共建平台 hard 困难问题 middle middle level of difficulties and removed hard 困难问题 labels Aug 16, 2024
@epoll-j
Copy link
Collaborator

epoll-j commented Aug 28, 2024

认领checkbox组件升级

epoll-j added a commit to epoll-j/tdesign-mobile-react that referenced this issue Aug 29, 2024
@epoll-j
refactor(checkbox): checkbox及checkboxgroup结构对齐vue
46c9e78 
re Tencent#459
@epoll-j epoll-j mentioned this issue Aug 29, 2024
Merged
16 tasks
byq1213 added a commit to byq1213/tdesign-mobile-react that referenced this issue Sep 3, 2024
@byq1213
feat(checkbox): rebuild checkbox & demo
9b84ed9 
fix Tencent#459
@byq1213 byq1213 mentioned this issue Sep 3, 2024
Closed
16 tasks
byq1213 added a commit to byq1213/tdesign-mobile-react that referenced this issue Sep 3, 2024
@byq1213
feat(checkbox): rebuild checkbox & demo
439cc2b 
fix Tencent#459
@byq1213 byq1213 mentioned this issue Sep 3, 2024
Closed
16 tasks
@epoll-j epoll-j mentioned this issue Sep 3, 2024
Merged
16 tasks
byq1213 added a commit to byq1213/tdesign-mobile-react that referenced this issue Sep 4, 2024
@byq1213
fix(checkbox): checkbox-group type
6b314ed 
fix Tencent#459
anlyyao pushed a commit that referenced this issue Sep 18, 2024
@epoll-j
Checkbox组件样式及功能对齐Vue (#504)
335272c 
* refactor(checkbox): type.ts定义对齐vue

* refactor(checkbox): checkbox及checkboxgroup结构对齐vue

re #459

* refactor(checkbox): 调整checkboxgroup结构

* refactor(checkbox): 类型及状态示例对齐vue

* refactor(checkbox): 样式及特殊样式示例对齐vue

* refactor(checkbox): 修复非受控选择bug

* refactor(checkbox): checkbox代码优化

* refactor(checkbox): 修复全选图标错误bug

* refactor(checkbox): 选中样式调整

* refactor(checkbox): 统一checked状态判断逻辑

* refactor(checkbox): 示例文件修改为tsx

* perf: 修改checkbox类名获取方式

* chore: 更新checkbox测试快照

* chore: 合并develop分支, 重新更新demo快照

* docs(checkbox): checkbox api文档对齐vue

* perf(checkbox): checkbox组件添加displayName属性

* docs(checkbox): 文档移除vue相关路径

* perf(checkbox): 根据review优化相关逻辑#504

* docs(checkbox): 根据tdesign-api重新生成文档及移除多余样式

* fix(checkboxGroup): 修复类型错误

* feat(checkbox): 新增支持readonly属性
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issueshoot 代码共建平台 middle middle level of difficulties
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checkbox组件样式及功能对齐Vue epoll-j/tdesign-mobile-react
2 participants
@epoll-j @anlyyao