Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(navbar): 更新navbar组件属性参数和实现 #450

Merged
merged 12 commits into from
Aug 23, 2024

Conversation

04756
Copy link
Contributor

@04756 04756 commented Aug 11, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #417

💡 需求背景和解决方案

  1. 重构Navbar样式, 对齐mobile-vue的Navbar组件效果。
  2. 参照mobile-vue的Navbar组件效果和API,重构react端代码。
    image
    image
    image

📝 更新日志

  • breaking(Navbar): 组件重构,移除 homeIconleftIconrightIcon 等属性、移除 onHomeClick 事件,新增 capsuleleftleftArrowright 等属性、新增 onRightClick

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Aug 12, 2024

完成

Copy link
Collaborator

@HaixingOoO HaixingOoO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TNode类型的需要使用parseTNode来渲染,你项目里没有的话,需要merge一下develop分支

Copy link
Collaborator

@HaixingOoO HaixingOoO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navbar.md英文的是不是少修改了,然后例子都需要把jsx改成tsx,type是不是少了一下字段,没拉取最新的tdesign-api的文件吗?

src/navbar/Navbar.tsx Outdated Show resolved Hide resolved
src/common.ts Outdated Show resolved Hide resolved
@04756
Copy link
Contributor Author

04756 commented Aug 13, 2024

navbar.md英文的是不是少修改了,然后例子都需要把jsx改成tsx,type是不是少了一下字段,没拉取最新的tdesign-api的文件吗?

之前对api平台中心理解有误。新提交本地运行了tdesign-api进行了文件生成覆盖。
同时已经拉取最新develop分支,重新rebase啦。TNode类型属性用parseTNode进行了包裹。

@HaixingOoO
Copy link
Collaborator

HaixingOoO commented Aug 13, 2024

之前对api平台中心理解有误。新提交本地运行了tdesign-api进行了文件生成覆盖。 同时已经拉取最新develop分支,重新rebase啦。TNode类型属性用parseTNode进行了包裹。

ok

@04756 04756 force-pushed the feature/navbar branch 2 times, most recently from 8f9644a to 47667e4 Compare August 15, 2024 16:10
@04756
Copy link
Contributor Author

04756 commented Aug 16, 2024

@HaixingOoO emm,我本地运行test:snap-update,报错
12c72896b32423da8643041d90632ff
请问该如何处理呀?

@HaixingOoO
Copy link
Collaborator

/update-snapshot

@HaixingOoO
Copy link
Collaborator

@anlyyao @uyarn 你们看看什么原因,是不是更新tdesign-icon package的问题?

@uyarn
Copy link
Collaborator

uyarn commented Aug 18, 2024

@anlyyao @uyarn 你们看看什么原因,是不是更新tdesign-icon package的问题?

没有更新图标,看看本地的node 版本 @04756

@04756
Copy link
Contributor Author

04756 commented Aug 18, 2024

@anlyyao @uyarn 你们看看什么原因,是不是更新tdesign-icon package的问题?

没有更新图标,看看本地的node 版本 @04756

node是16.14版本。拉取最新develop分支合并,重新安装依赖后test:snap-update命令正常执行了~

@anlyyao
Copy link
Collaborator

anlyyao commented Aug 21, 2024

/update-snapshot

@04756
Copy link
Contributor Author

04756 commented Aug 21, 2024

/update-snapshot

done

src/navbar/Navbar.tsx Outdated Show resolved Hide resolved
@HaixingOoO
Copy link
Collaborator

@anlyyao review done

@anlyyao anlyyao merged commit 1050903 into Tencent:develop Aug 23, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【Navbar组件升级】任务单
4 participants