Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popup): popup对齐vue mobile #449

Merged
merged 10 commits into from
Aug 21, 2024
Merged

Conversation

hkaikai
Copy link
Contributor

@hkaikai hkaikai commented Aug 8, 2024

fix #407

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#407
api变更:TDesignOteam/tdesign-api#362
common变更:Tencent/tdesign-common#1867

💡 需求背景和解决方案

📝 更新日志

  • breaking(Popup): 组件重构,新增 attachcloseBtncloseOnOverlayClickdestroyOnClosepreventScrollThrough 等属性,新增 onCloseonClosedonOpenonOpened 等事件

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Aug 9, 2024

完成

Copy link
Collaborator

@HaixingOoO HaixingOoO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Popup.defaultProps = popupDefaultProps;
需要改用useDefaultPropshooks,defaultProps在React19删掉了

src/overlay/Overlay.tsx Outdated Show resolved Hide resolved
src/popup/Popup.tsx Outdated Show resolved Hide resolved
src/popup/Popup.tsx Outdated Show resolved Hide resolved
src/popup/Popup.tsx Outdated Show resolved Hide resolved
src/common.ts Outdated Show resolved Hide resolved
src/popup/Popup.tsx Outdated Show resolved Hide resolved
src/button/Button.tsx Outdated Show resolved Hide resolved
@anlyyao
Copy link
Collaborator

anlyyao commented Aug 20, 2024

@HaixingOoO 有空在看看这里 👀

@HaixingOoO
Copy link
Collaborator

@HaixingOoO 有空在看看这里 👀

@anlyyao
Copy link
Collaborator

anlyyao commented Aug 21, 2024

/update-common

@anlyyao
Copy link
Collaborator

anlyyao commented Aug 21, 2024

/update-snapshot

@anlyyao anlyyao merged commit ee54e86 into Tencent:develop Aug 21, 2024
6 checks passed
@hkaikai hkaikai deleted the feature/popup branch August 21, 2024 08:23
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【Popup组件升级】任务单
3 participants