Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): do scrollTo after scroll range reduce #3770

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix(android): do scrollTo after scroll range reduce #3770

merged 2 commits into from
Mar 7, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added framework: android size: s Denotes a PR that changes 10-99 lines labels Mar 7, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Mar 7, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@siguangli siguangli requested a review from iPel March 7, 2024 06:59
iPel
iPel previously approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@iPel iPel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hippy-service Hippy Service
Copy link

hippy-service bot commented Mar 7, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Mar 7, 2024
@siguangli siguangli added the action(squash-merge) Squash and merge action label Mar 7, 2024
@hippy-actions hippy-actions bot enabled auto-merge (rebase) March 7, 2024 07:38
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Mar 7, 2024
@hippy-actions Hippy Actions
Copy link

hippy-actions bot commented Mar 7, 2024

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@siguangli

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Mar 7, 2024
@siguangli siguangli requested a review from iPel March 7, 2024 07:45
iPel
iPel approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@iPel iPel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@siguangli siguangli added the action(squash-merge) Squash and merge action label Mar 7, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Mar 7, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Mar 7, 2024
@hippy-actions hippy-actions bot removed the action(squash-merge): failed Squash and merge action execution failed label Mar 7, 2024
@hippy-actions Hippy Actions
Copy link

hippy-actions bot commented Mar 7, 2024

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@siguangli

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Mar 7, 2024
@hippy-actions hippy-actions bot disabled auto-merge March 7, 2024 08:00
@hippy-actions hippy-actions bot enabled auto-merge (rebase) March 7, 2024 08:00
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Mar 7, 2024
@siguangli siguangli disabled auto-merge March 7, 2024 08:06
@siguangli siguangli merged commit aca49e5 into Tencent:master Mar 7, 2024
44 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPel iPel iPel approved these changes

Assignees
No one assigned
Labels
action(squash-merge): failed Squash and merge action execution failed framework: android size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siguangli @iPel @siguangli2018