fix(core): support onerror for js #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etkmao
requested review from
ozonelmy,
wwwcg,
ilikethese,
lvfen,
skindhu,
siguangli,
iPel and
zealotchen0
as code owners
github-actions
bot
added
framework: android
driver: js
module: vfs
framework: voltron
size: m
|
Hi, @etkmao. Thanks for your PR! 👏 🏷️ You can leave a comment in this PR with |
etkmao
force-pushed
the
feature/onerror2
branch
2 times, most recently
from
1d72a4b
to
887fd10
Compare
ozonelmy
previously approved these changes
Aug 31, 2023
etkmao
force-pushed
the
feature/onerror2
branch
from
887fd10
to
357c7d3
Compare
lvfen
previously approved these changes
Sep 1, 2023
ilikethese
previously approved these changes
Sep 1, 2023
etkmao
dismissed stale reviews from ilikethese, lvfen, and ozonelmy
via
8934597
etkmao
force-pushed
the
feature/onerror2
branch
from
8934597
to
c23830f
Compare
wwwcg
previously approved these changes
Sep 1, 2023
modules/vfs/ios/VFSUriLoader.mm
Outdated
| @@ -146,6 +146,10 @@ | |||
| auto endPoint = footstone::TimePoint::SystemNow(); | |||
| string_view uri(NSStringToU16StringView([[response URL] absoluteString])); | |||
| DoRequestTimePerformanceCallback(uri, startPoint, endPoint); | |||
| if (error.code != 0) { | |||
| string_view msg([error.localizedDescription UTF8String]?:""); | |||
| DoRequestErrorCallback(uri, static_cast<int32_t>(error.code), msg); | |||
ilikethese
previously approved these changes
Sep 4, 2023
etkmao
force-pushed
the
feature/onerror2
branch
2 times, most recently
from
f642ca3
to
300f114
Compare
iPel
previously approved these changes
Sep 4, 2023
etkmao
force-pushed
the
feature/onerror2
branch
from
8b70d7d
to
47ac652
Compare
wwwcg
previously approved these changes
Sep 5, 2023
iPel
previously approved these changes
Sep 5, 2023
ilikethese
previously approved these changes
Sep 5, 2023
siguangli
dismissed stale reviews from ilikethese, iPel, and wwwcg
via
d9efa37
siguangli
previously approved these changes
Sep 5, 2023
wwwcg
approved these changes
Sep 5, 2023
iPel
approved these changes
Sep 5, 2023
ilikethese
approved these changes
Sep 5, 2023
ozonelmy
approved these changes
Sep 5, 2023
siguangli
approved these changes
Sep 5, 2023
lvfen
approved these changes
Sep 5, 2023
|
🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.
|
zealotchen0
approved these changes
Sep 5, 2023
wwwcg
pushed a commit
to wwwcg/Hippy
that referenced
this pull request
Sep 6, 2023
* fix(core): support onerror for js * fix(android): add res load reslut to record jni * fix(core): support onerror for js --------- Co-authored-by: etkmao <[email protected]> Co-authored-by: maxli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a new pull request, please make sure: