From f69d2990dd09aee67722f6fff031c323eedcbce5 Mon Sep 17 00:00:00 2001 From: arnonchen <745735906@qq.com> Date: Fri, 15 Nov 2024 21:27:35 +0800 Subject: [PATCH] fix(devtools): fix the name of function --- .../native/include/devtools/devtools_utils.h | 2 +- .../devtools-integration/native/src/devtools_utils.cc | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/devtools/devtools-integration/native/include/devtools/devtools_utils.h b/devtools/devtools-integration/native/include/devtools/devtools_utils.h index 041bc45fa20..efdf1323818 100644 --- a/devtools/devtools-integration/native/include/devtools/devtools_utils.h +++ b/devtools/devtools-integration/native/include/devtools/devtools_utils.h @@ -56,7 +56,7 @@ class DevToolsUtil { static bool ShouldAvoidPostDomManagerTask(const std::string& event_name); private: - static hippy::dom::DomArgument makeLocationArgument(double x, double y); + static hippy::dom::DomArgument MakeLocationArgument(double x, double y); static std::shared_ptr GetHitNode(const std::shared_ptr& root_node, double x, double y); static std::string ParseNodeKeyProps(const std::string& node_key, const NodePropsUnorderedMap& node_props); static std::string ParseNodeProps(const NodePropsUnorderedMap& node_props); diff --git a/devtools/devtools-integration/native/src/devtools_utils.cc b/devtools/devtools-integration/native/src/devtools_utils.cc index d2aa412543b..c522daa6d26 100644 --- a/devtools/devtools-integration/native/src/devtools_utils.cc +++ b/devtools/devtools-integration/native/src/devtools_utils.cc @@ -137,7 +137,7 @@ auto MakeCopyable(F&& f) { }; } -hippy::dom::DomArgument DevToolsUtil::makeLocationArgument(double x, double y) { +hippy::dom::DomArgument DevToolsUtil::MakeLocationArgument(double x, double y) { footstone::value::HippyValue::HippyValueObjectType hippy_value_object; hippy_value_object[kXOnScreen] = footstone::value::HippyValue(x); hippy_value_object[kYOnScreen] = footstone::value::HippyValue(y); @@ -160,8 +160,8 @@ std::shared_ptr DevToolsUtil::GetHitNode(const std::shared_ptr arg) mutable { footstone::value::HippyValue result_hippy_value; arg->ToObject(result_hippy_value); @@ -177,7 +177,7 @@ std::shared_ptr DevToolsUtil::GetHitNode(const std::shared_ptr(result_dom_object.find(kHippyTag)->second.ToInt32Checked()); promise.set_value(hippyTag); }); - base_node->CallFunction(kGetViewTagByLocation, argument, screen_shot_callback); + base_node->CallFunction(kGetViewTagByLocation, argument, get_view_tag_callback); std::chrono::milliseconds span(10); if (read_file_future.wait_for(span) == std::future_status::timeout) { FOOTSTONE_DLOG(WARNING) << kDevToolsTag << "GetHitNode wait_for timeout";