feat(voltron): update workflow xcode version

Tencent · Jul 4, 2023 · f261ef0 · f261ef0
1 parent a802e22
commit f261ef0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/voltron_build_tests.yml b/.github/workflows/voltron_build_tests.yml
@@ -91,7 +91,7 @@ jobs:
         working-directory: framework/voltron
 
   voltron_ios_flutter_build:
-    runs-on: macos-latest
+    runs-on: macos-13
     steps:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
@@ -103,3 +103,5 @@ jobs:
         run: flutter pub get
       - name: Build for iOS
         run: flutter build ios --release --no-codesign
+    env:
+      DEVELOPER_DIR: /Applications/Xcode_14.3.1.app/Contents/Developer
diff --git a/framework/voltron/core/src/bridge/ios/VoltronJSCExecutor.mm b/framework/voltron/core/src/bridge/ios/VoltronJSCExecutor.mm
@@ -199,11 +199,11 @@ - (void)setup {
 
             std::shared_ptr<hippy::napi::JSCCtx> context = std::static_pointer_cast<hippy::driver::napi::JSCCtx>(scope->GetContext());
             JSContext *jsContext = [JSContext contextWithJSGlobalContextRef:context->GetCtxRef()];
-//            #if __IPHONE_OS_VERSION_MAX_ALLOWED > __IPHONE_16_2
-//                if (@available(iOS 16.4, *)) {
-//                    jsContext.inspectable = true;
-//                }
-//            #endif
+            #if defined(__IPHONE_16_4) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_16_4
+                if (@available(iOS 16.4, *)) {
+                    jsContext.inspectable = true;
+                }
+            #endif
             auto global_object = context->GetGlobalObject();
             auto user_global_object_key = context->CreateString(kGlobalKey);
             context->SetProperty(global_object, user_global_object_key, global_object);