fix(core): fix performance for dom node

Tencent · Sep 4, 2023 · 7da2c69 · 7da2c69
1 parent 208ba93
commit 7da2c69
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/dom/src/dom/dom_node.cc b/dom/src/dom/dom_node.cc
@@ -103,13 +103,13 @@ std::shared_ptr<DomNode> DomNode::GetChildAt(size_t index) {
 }
 
 int32_t DomNode::AddChildByRefInfo(const std::shared_ptr<DomInfo>& dom_info) {
-  std::shared_ptr<RefInfo> ref_info = dom_info->ref_info;
+  std::shared_ptr<RefInfo>& ref_info = dom_info->ref_info;
   if (ref_info) {
     if (children_.size() == 0) {
        children_.push_back(dom_info->dom_node);
     } else {
       for (uint32_t i = 0; i < children_.size(); ++i) {
-        auto child = children_[i];
+        auto& child = children_[i];
         if (ref_info->ref_id == child->GetId()) {
           if (ref_info->relative_to_ref == RelativeType::kFront) {
             children_.insert(
@@ -145,7 +145,7 @@ int32_t DomNode::AddChildByRefInfo(const std::shared_ptr<DomInfo>& dom_info) {
 int32_t DomNode::GetChildIndex(uint32_t id) {
   int32_t index = -1;
   for (uint32_t i = 0; i < children_.size(); ++i) {
-    auto child = children_[i];
+    auto& child = children_[i];
     if (child && child->GetId() == id) {
       index = static_cast<int32_t>(i);
       break;

diff --git a/dom/src/dom/root_node.cc b/dom/src/dom/root_node.cc
@@ -74,7 +74,7 @@ void RootNode::CreateDomNodes(std::vector<std::shared_ptr<DomInfo>>&& nodes) {
   }
   std::vector<std::shared_ptr<DomNode>> nodes_to_create;
   for (const auto& node_info : nodes) {
-    auto node = node_info->dom_node;
+    auto& node = node_info->dom_node;
     std::shared_ptr<DomNode> parent_node = GetNode(node->GetPid());
     if (parent_node == nullptr) {
       continue;