Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you Update IOS SDK? #58

Open
lbweb opened this issue Oct 14, 2016 · 6 comments · May be fixed by #65
Open

How do you Update IOS SDK? #58

lbweb opened this issue Oct 14, 2016 · 6 comments · May be fixed by #65
Assignees
Milestone

Comments

@lbweb
Copy link

lbweb commented Oct 14, 2016

Hi All,
In a separate pull request listed by @dagatsoin here he says:

"The Mapbox SDK is now iOS 3.2.0 and also fixes a memory leak which add 30-50mo each time the user show/hide the map"

I am having this exact issue! Can someone explain how to update the IOS SDK sitting behind the Telerik plugin to 3.20?

Please note: I am using @Anothar's fork here

@risinghero
Copy link
Contributor

Hi, @lbweb . You can look at @dagatsoin commit changes and try to change the same way. But I don't recommend for the following reason: I was unable to make .framework work. So it's better to wait for @dagatsoin answer whether it works or try his fork. If it works it' s not so hard to integrate his code regarding version. If not - it will be painful. I'll have to remember how to compile .framework into library and it will take time.

@dagatsoin
Copy link

dagatsoin commented Oct 15, 2016

@lbweb I can't make a better answer than @Anothar. Just take a look to my commit. As I remember I did not compile anything, I just downloaded the sdk from here then declared the new frameworks and the needed files in plugin.xml. Cordova did the rest.

@lbweb
Copy link
Author

lbweb commented Oct 19, 2016

@Anothar @dagatsoin Thanks guys! Will investigate further and update this thread.

@lbweb
Copy link
Author

lbweb commented Nov 15, 2016

HI @dagatsoin,
In terms of upgrading the IOS Mapbox SDK to 3.20 (as discussed above) - I've followed your commit listed but I'm getting one last build error which I can't get to the bottom of!

It has to do with the CDVMapbox.m file - I checked the file and all the other files its trying to import are also there. Can you point me in the right direction on what could be going wrong here? Did you have a similar error when you upgraded the underlying SDK to 3.2?

The following build commands failed: CompileC build/BPMap2.build/Debug-iphonesimulator/BPMap2.build/Objects-normal/i386/CDVMapbox.o BPMap2/Plugins/cordova-plugin-mapbox/CDVMapbox.m normal i386 objective-c com.apple.compilers.llvm.clang.1_0.compiler

@dagatsoin
Copy link

ouch... I haven't got a clue as to what the hell is this. And no, I had not got this error.
My 2 cts:

  • could be a Xcode version pb. Last time I work on iOS was on a old Xcode/iOS version (maybe 8, I don't remember.)
  • could be a architecture target pb. i386 is for desktop, is not?

@cusspvz
Copy link
Contributor

cusspvz commented Dec 28, 2016

Planing to update iOS, don't know to which version yet.
Not only because of this issue, but because I've experienced runtime delays on iOS 10.2.x.

Adding it to the next milestone.

@dagatsoin @EddyVerbruggen Do you know in advance which version should we choose without breaking changes on the API we're using?

@cusspvz cusspvz added this to the 1.3.0 milestone Dec 28, 2016
@cusspvz cusspvz linked a pull request Dec 29, 2016 that will close this issue
@cusspvz cusspvz self-assigned this Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants