[Feature] Offline map

[dagatsoin]

Any plans to support offline features? Coming march the 15 on ios/android

mapbox/mapbox-gl-native#4178

[EddyVerbruggen]

We love to support all major sweet features of Mapbox so yeah! Please remind me when you see it released and want to use it.

[dagatsoin]

Roger that. If you need some help to do it I would love to collaborate on the JS part if you think I have the level for.

[EddyVerbruggen]

I don't have high standards anyway ;) Any help is truly welcome 👍

[dagatsoin]

@EddyVerbruggen I just git flow feature start offlineMap so I am ready to help!
In addition to support offline map I would need also to expose some useful methods like:

• convertCoordinate:toPointToView
• convertPoint:toCoordinateFromView
• and find a way to expose the GL matrix/camera props [Question] Is this possible to match the MGL view point in another (non Mapbox) opengl/webgl view? mapbox/mapbox-gl-native#3668 (comment)

My goal is to be expose essential information to sync a 2d or a 3d overlay (with three.js/pixi.js). That also could serves #15

Do you think we can include that in the next release? What could be improve/add? Maybe #20 and #21?

[EddyVerbruggen]

Woohoo! Excited :)

It's probably best to keep the changes (PR's) small so they're easy to merge and test for everybody.

👍

[dagatsoin]

Ok. This is the first time for me to collaborate on a github repo so I am not very confortable with PR's yet.
I have forked the repo and I am working on exposing convertCoordinate. I will try to do a PR just for this when it will work.

[dagatsoin]

@EddyVerbruggen I think I need help to kickstart my work. It is the first time I customize a Cordova plugin.
I try to test my method exposition but receive

2016-03-25 17:55:16.203 HelloCordova[26812:753763] ERROR: Method '<null>:' not defined in Plugin 'Mapbox'
2016-03-25 17:55:16.203 HelloCordova[26812:753763] -[CDVCommandQueue executePending] [Line 142] FAILED pluginJSON = ["Mapbox1695989219","Mapbox",null,[]]

in CDVMapbox.h
- (void) convertCoordinate:(CDVInvokedUrlCommand*)command;
in CDVMapbox.m

- (void) convertCoordinate:(CDVInvokedUrlCommand *)command {
    NSDictionary *args = [command.arguments objectAtIndex:0];

    NSNumber *lat = [args valueForKey:@"lat"];
    NSNumber *lng = [args valueForKey:@"lng"];

    CGPoint screenPoint = [_mapView  convertCoordinate:CLLocationCoordinate2DMake(lat.doubleValue, lng.doubleValue)
                                         toPointToView:_mapView];

    NSArray * point = [NSArray arrayWithObjects:
                       [NSNumber numberWithFloat:screenPoint.x],
                       [NSNumber numberWithFloat:screenPoint.y],
                       nil];

    CDVPluginResult *pluginResult = [ CDVPluginResult
                                     resultWithStatus: CDVCommandStatus_OK
                                     messageAsArray: point
                                     ];
    [self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
}

in Mapbox.js

   convertCoordinate: function(options, successCallback, errorCallback){
    cordova.exec(successCallback, errorCallback, "Mapbox", "convertCoordinate" [options]);
  },

Do I miss a declaration somewhere?

[EddyVerbruggen]

That's all looking fine. Can you commit and push that code to your fork? Then I'll take a look if you like.

[dagatsoin]

I pushed it here https://github.com/dagatsoin/Mapbox/tree/feature/convertCoordinate

[EddyVerbruggen]

Take a long 👓 at this:

[dagatsoin]

5s later --> OMG!!

[dagatsoin]

WIP. Close this :)

[vinibiso]

Hi guys.

I read the thread and don't know what's the state of the implementation of using the offline feature of the native Mapbox with cordova?

I didn't see anything in the docs. Furthermore, I would love to help out with anything I can.

[dagatsoin]

I will work on it next weeks for iOS and Android in #29 and it should already work with #22

[vinibiso]

Oh hey.

Thanks for the update. I was kind of lost.

Thanks you.