Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixedToTop #1080

Open
pladaria opened this issue Apr 12, 2024 · 1 comment
Open

FixedToTop #1080

pladaria opened this issue Apr 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@pladaria
Copy link
Member

pladaria commented Apr 12, 2024

Current implementation

The ThemeContextProvider accepts to configure the dimensions of the NavigationBar:

    dimensions: {
        headerMobileHeight: number;
        headerDesktopHeight: number;
    };

But these dimensions are not being used by the NavigationBar component

There is a context named FixedToTop that allows to set the height of the elements that are being placed to the top (like a NavigationBar) but the NavigationBar component isn't using it, instead, as we see in the "default-page-layout" in webapp, this is manually used:

https://github.com/Telefonica/webapp/blob/master/web/src/common/components/default-page-layout.tsx#L51

Possible improvements

  • The NavigationBar component should set its height according to the dimensions value from the theme
  • The NavigationBar component should set the FixedToTop context value
@pladaria pladaria added the enhancement New feature or request label Apr 12, 2024
@pladaria
Copy link
Member Author

comment from teams
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant