Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User selectable manual audio delay #11200

Closed
6 tasks done
5225225 opened this issue Jun 21, 2024 · 7 comments
Closed
6 tasks done

User selectable manual audio delay #11200

5225225 opened this issue Jun 21, 2024 · 7 comments
Labels
player Issues related to any player (main, popup and background) question Not really an issue, but more of a question about how something works

Comments

@5225225
Copy link

5225225 commented Jun 21, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

A user selectable audio delay that is tied to the Bluetooth device in use. Probably allow just typing in a (positive or negative, but delaying the video to sync up with audio is more useful for me) millisecond value.

Why do you want this feature?

My Bluetooth headphones have around 200ms of latency on them, and when I watch videos with them on, its quite jarring. (A secondary use which would be to fix audio sync on a per-video basis)

(I've heard there's a feature to let headphones tell the phone what delay they have, but either this is not implemented for my headphones, or it needs player support which doesn't exist (yet))

Additional information

VLC has this feature and it works well in my experience, I just set a audio delay and tell VLC to always use that delay for my given Bluetooth headphones. (It uses no delay when using phone speakers).

The UI looks like this (but I wouldn't copy the "sound heard / sound seen" personally, I would just allow the user to type in a delay and expect them to figure out the correct delay).

Screenshot_20240622-004946

And as requested by the template, here's a picture of a cat I saw a while back :3
markup_4110

@5225225 5225225 added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jun 21, 2024
@opusforlife2 opusforlife2 added player Issues related to any player (main, popup and background) and removed needs triage Issue is not yet ready for PR authors to take up labels Jun 23, 2024
@5225225
Copy link
Author

5225225 commented Jun 23, 2024

Actually... I tested it again with my current headphones and it does seem like the latency is automatically adjusted. Maybe it's a newer firmware thing?

I think the feature request is still valid though, since I'm not sure if all headphones support it, but it's at least not too important for me personally anymore.

@opusforlife2
Copy link
Collaborator

I searched, and Exoplayer does have the ability to automatically compensate for Bluetooth audio lag. Not sure what was going on with your older headphones.

Anyway, if another user faces this they can always open an issue.

@opusforlife2 opusforlife2 added question Not really an issue, but more of a question about how something works and removed feature request Issue is related to a feature in the app labels Jun 23, 2024
@jakariyaa
Copy link

jakariyaa commented Oct 12, 2024

Hello! I have this exact issue with YouTube/NewPipe. My earbuds also have ~200ms and it's really annoying to watch videos with lips out of sync. I can get away with this latency by setting a video delay in MX player (also in VLC player) it would be really nice to similar option in NewPipe. So please reopen this issue @opusforlife2

Bluetooth audio delay option
An screenshot of Mx Player having this Bluetooth audio delay option

@opusforlife2
Copy link
Collaborator

@jakariyaa Do you get a lag using https://f-droid.org/en/packages/com.brouken.player/ ?

@jakariyaa
Copy link

@jakariyaa Do you get a lag using https://f-droid.org/en/packages/com.brouken.player/ ?

Yes @opusforlife2, I still get this audio lag with this mentioned player.

Tested version: https://github.com/moneytoo/Player/releases/tag/v0.170

@opusforlife2
Copy link
Collaborator

@jakariyaa Please open a new issue. Although a bug report about this should also really be opened in the upstream Exoplayer/Media3 repo, we might also consider adding this as a feature in Newpipe's player specifically because lots of different quirky Bluetooth listening devices may exist out there.

@jakariyaa
Copy link

@opusforlife2 I have opened this similar issue in the repo of NewPlayer:
TeamNewPipe/NewPlayer#9

I hope it was the right place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
player Issues related to any player (main, popup and background) question Not really an issue, but more of a question about how something works
Projects
None yet
Development

No branches or pull requests

3 participants