New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup after horizon migration #39

Open

TbLtzk opened this issue Nov 6, 2015 · 1 comment

Labels

architecture non functional

Owner

TbLtzk commented Nov 6, 2015

remove everything that remains from old websocket
remove websocket plugin
call other plugins into question
Use Account.isValidAddress()
call healthCheck into question
analyze upgrade to higher versions of
- ionic
- cordova

TbLtzk added the architecture label

TbLtzk added the non functional label

Owner Author

TbLtzk commented Dec 30, 2015

part of websocket stuff is removed but still more to investigate: https://github.com/raymens/Centaurus/blob/master/www/js/services/services.basic.js#L108-L133 which should not be needed anymore. The healthcheck might be useful later but at the moment is not, because isConnected() always returns true.
Might check the goodbye-stellard branch to see how it used to be..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment