Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Message length exceeded maximum allowed length" on script update #2285

Open
redweller opened this issue Dec 9, 2024 · 7 comments
Open

"Message length exceeded maximum allowed length" on script update #2285

redweller opened this issue Dec 9, 2024 · 7 comments
Labels
Milestone

Comments

@redweller
Copy link

redweller commented Dec 9, 2024

Expected Behavior

Script is installed.

Actual Behavior

Infinite "Please wait" window.

People are having trouble installing a userscript on Chrome. This userscript gave no issues in the past, and it still can be successfully installed on Edge and FF.

When clicking the link to the script, TM opens the import tab and says "Please wait", then a file save dialogue pops. After that the Please wait message remains forever. This actually happens whenever the script is loaded - via link, via file, or if I manually copy paste it, change the version to a lower one and try updating. But if I copy-paste the script, it works. The other scripts I have tested are installed as usual.

UPDATE I've been assuming that this error happens on any install/update operation, but it turns out the fresh install is OK, but any subsequent updates except for the manual copy/pasting the code, result in the infinite "Please wait" window. Also it seems this has something to do with the size of the script being updated. Scripts >30Mb have this behavior.

Specifications

  • Chrome: 131.0.6778.109
  • TM: 5.3.3
  • OS: Win11

Script

// ==UserScript==
// @name         betteR20-beta-5etools
// @namespace    https://5e.tools/
// @license      MIT (https://opensource.org/licenses/MIT)
// @version      1.35.186.13
// @updateURL    https://raw.githubusercontent.com/redweller/betterR20/dev-beta/dist/betteR20-5etools.meta.js
// @downloadURL  https://raw.githubusercontent.com/redweller/betterR20/dev-beta/dist/betteR20-5etools.user.js
// @description  Enhance your Roll20 experience
// @author       5egmegaanon/astranauta/MrLabRat/TheGiddyLimit/DBAWiseMan/BDeveau/Remuz/Callador Julaan/Erogroth/Stormy/FlayedOne/Cucucc/Cee/oldewyrm/darthbeep/Mertang/Redweller

// @match        https://app.roll20.net/editor
// @match        https://app.roll20.net/editor#*
// @match        https://app.roll20.net/editor?*
// @match        https://app.roll20.net/editor/
// @match        https://app.roll20.net/editor/#*
// @match        https://app.roll20.net/editor/?*

// @grant        unsafeWindow
// @run-at       document-start

// @grant        GM_webRequest
// ==/UserScript==
@derjanb
Copy link
Member

derjanb commented Dec 9, 2024

Can not reproduce.

Please open the developer tools (ctrl+shift+j) and check the console tab for error messages.

@derjanb
Copy link
Member

derjanb commented Dec 9, 2024

Please also check the background console for errors -> https://tmnk.net/faq#Q600

@redweller
Copy link
Author

Please also check the background console for errors -> https://tmnk.net/faq#Q600

image

@redweller
Copy link
Author

Update: I've emptied my TM trash bin, and the script can be installed again. But any update operation leads to the same error, Below is the console output that happens when I just try to check for updates. In this case, it doesn't show the "download file" dialog, and the two subsequent console messages don't appear, just the "Please wait..." stuck forever

image

@redweller
Copy link
Author

Some further research showed that the issue is indeed only related to script updates, and depends entirely on the current script, the one it's being updated to seems irrelevant. Also, as a hypothesis, this happens when the current script exceeds 30Mb size. I'm not absolutely sure, but it seems like it.

@redweller
Copy link
Author

Also, Im sorry for the initial confusion. It's just the first person to report this said they were trying to "install" the script, so it didn't occur to me to explicitly check the fresh install.

@redweller redweller changed the title Infinite "Please wait" while installing a script on Chrome Infinite "Please wait" while updating a script on Chrome Dec 9, 2024
@derjanb derjanb changed the title Infinite "Please wait" while updating a script on Chrome "Message length exceeded maximum allowed length" on script update Dec 9, 2024
@derjanb derjanb added this to the 5.4 milestone Dec 9, 2024
@derjanb
Copy link
Member

derjanb commented Dec 9, 2024

Also, Im sorry for the initial confusion.

No problem. I can reproduce it now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants