Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New QR code spam banner too big + re-appears when previously dismissed #2242

Closed
adamlui opened this issue Nov 13, 2024 · 30 comments
Closed

New QR code spam banner too big + re-appears when previously dismissed #2242

adamlui opened this issue Nov 13, 2024 · 30 comments

Comments

@adamlui
Copy link

adamlui commented Nov 13, 2024

image

Expected Behavior

QR spam to be porportional to menu items and not re-appear post-dismissal

Actual Behavior

It is bulky and awkward, last re-appearance was today on TM auto-update (2024-10-29 ver)

Specifications

  • Firefox: 132.0.1
  • TM: 5.3.2
  • OS: Win10

Also most mobile browsers don't support Chrome extensions so if QR code leads to CWS listing, the Install button will be disabled most of the time (instead, if you must spam, link to a page of supported browsers, that's the biggest obstacle users must overcome, then they will search for TM already so QR code is not useful)

@adamlui
Copy link
Author

adamlui commented Nov 13, 2024

Also I recall testing mobile browsers that simply don't like TM (e.g. popular Kiwi) even with Dev Mode on, but work with other managers, so your priority should be build a list of TM-friendly browsers for the recommendation page

@adamlui
Copy link
Author

adamlui commented Nov 13, 2024

The ones that were confirmed working last I tested were:

(but non-CWS vers weren't updated to MV3 yet, so they may all not work now)

@derjanb
Copy link
Member

derjanb commented Nov 26, 2024

QR spam to be proportional to menu items and not re-appear post-dismissal

Will be fixed...

so if QR code leads to CWS listing, the Install button will be disabled most of the time (instead, if you must spam, link to a page of supported browsers, that's the biggest obstacle users must overcome, then they will search for TM already so QR code is not useful)

Scanning the QR code (with FF icon) should lead you to Firefox's play store entry or Tampermonkey (at AMO) if the link is opened in Firefox Android.

@derjanb
Copy link
Member

derjanb commented Nov 26, 2024

Also I recall testing mobile browsers that simply don't like TM (e.g. popular Kiwi) even with Dev Mode on

#2055

@derjanb derjanb added this to the 5.4 milestone Nov 26, 2024
@derjanb
Copy link
Member

derjanb commented Nov 26, 2024

not re-appear post-dismissal

It should not re-appear unless your browser profile is broken and can't save new data. You can test this by modifying a script and then restart FF. If the changes don't persist, then TM can't save any change anymore.

@adamlui
Copy link
Author

adamlui commented Nov 27, 2024

Scanning the QR code (with FF icon) should lead you to Firefox's play store entry or Tampermonkey (at AMO) if the link is opened in Firefox Android.

I'm saying Chrome users if led to CWS listing will not find it useful since it will not enable Install

#2055

I don't recall ever getting MV3 TM to work in a mobile browser that supported Chrome extensions w/ Dev Mode on but other managers worked, so to prevent losing mobile market share you should try to work around the issue like your competition

It should not re-appear unless your browser profile is broken and can't save new data. You can test this by modifying a script and then restart FF. If the changes don't persist, then TM can't save any change anymore.

Script mods are honored but next time if it happens I'll show a screenshot

@derjanb
Copy link
Member

derjanb commented Nov 27, 2024

I'm saying Chrome users if led to CWS listing will not find it useful since it will not enable Install

They will be forwarded to MS Edge at the play store. I worked with Microsoft and when installing Edge via this link, then Tampermonkey will be pre-installed.

next time if it happens I'll show a screenshot

Please check then the output of this command as well.

chrome.storage.local.get(['#misc_configglobal_hints.items'], e => console.log(e))

@derjanb
Copy link
Member

derjanb commented Nov 27, 2024

Should be fixed at 5.3.6221 (crx|xpi in review)

@adamlui
Copy link
Author

adamlui commented Nov 28, 2024

They will be forwarded to MS Edge at the play store. I worked with Microsoft and when installing Edge via this link, then Tampermonkey will be pre-installed.

I just opened Edge w/ TM installed and it doesn't work though (tapping script install link on GF leads to native download prompt instead, then visiting matched site shows nothing is affected)

My scripts have hundreds of thousands of users and I recommend other managers for Android use because of this.

Again, you should just copy how they work around the Chrome issues if you want a piece of their growing Android mobile market share (also when streaming text response from AI, TM crashes a lot of my users' browsers vs. your competition like VM and SC don't)

Please check then the output of this command as well.

chrome.storage.local.get(['#misc_configglobal_hints.items'], e => console.log(e))

chrome APIs don't work from console + storage keys are sandboxed to the extension calling it, so I would have to edit your extension's source code to successfully view this log unfortunately (but I recommend hide the spam outright until you get Android working right)

@adamlui
Copy link
Author

adamlui commented Nov 28, 2024

I may seem like a pesky annoyance but I have nothing against you, I simply raise issues as I experience them as they affect my many users too, also the fact your competitors who aren't even commercialized like yours rarely give my users any problems is why I recommend TM less and less these days (even as my first manager over 10 years ago)

@adamlui
Copy link
Author

adamlui commented Nov 28, 2024

Also a co-advisor of Mozilla's Community Advisory Board I'm on (we select/review FF add-ons nominated for Recommended badge) just nominated your competitor VM, specifically citing its superiority to TM... so you should reflect on why users are increasingly preferring other managers over yours (even though yours is so old thus should be most stable), then maybe follow my advice about copy them back (after fixing the bugs & issues)

@derjanb
Copy link
Member

derjanb commented Dec 15, 2024

chrome APIs don't work from console + storage keys are sandboxed to the extension calling it

Of course, you have to execute this at the background page/service worker. Sorry, I thought you were familiar with how to do this.

tapping script install link on GF leads to native download prompt instead, then visiting matched site shows nothing is affected

You found #2268 a little earlier, but I was unable to reproduce it back then. However, it's fixed now.

I simply raise issues as I experience them

Thanks! Keep up reporting issues.

Version 5.3.3 (FF version is in review) allows the QR code text to wrap. So the popup menu's width is not increased by the text anymore.
Besides this I'd like to keep it as is for now, even though the next BETA version makes the QR code a little bit smaller.

So closing this for now. Please re-open it, if you can reproduce the QR code re-appearing after being dismissed.

@derjanb derjanb closed this as completed Dec 15, 2024
@adamlui
Copy link
Author

adamlui commented Dec 15, 2024

Of course, you have to execute this at the background page/service worker. Sorry, I thought you were familiar with how to do this.

What are you talking about. This issue does not pertain to my Chrome extensions. Why are you asking me to edit a Chrome extension's service worker (unless you intended for me to edit Tampermonkey's which I find hard to believe given you previously spoke to me as if I'm a JS/Chrome noob, so it's more likely you thought users can log chrome methods' output from userscript which actually is possible in OrangeMonkey but not Tampermonkey)

You found #2268 a little earlier, but I was unable to reproduce it back then. However, it's fixed now.

IDK what you mean I found anything (never seen that issue in my life)

So closing this for now. Please re-open it, if you can reproduce the QR code re-appearing after being dismissed.

The people you close unresolved issues on cannot actually re-open them so you are making very strange comments as per usual

image

@adamlui
Copy link
Author

adamlui commented Dec 15, 2024

Are u mad?

@derjanb
Copy link
Member

derjanb commented Dec 15, 2024

What are you talking about.

In case you see the QR code after dismissing it, execute the given snippet at Tampermonkey's background page/service worker. It will output the internal state that remembers the dismissal.

chrome.storage.local.get(['#misc_configglobal_hints.items'], e => console.log(e))

cannot actually re-open them

Just comment here and I'll re-open the issue if you can reproduce the QR code re-appear post-dismissal. Thanks.

Are u mad?

Not sure what you mean by that and how it relates the issue.

@adamlui
Copy link
Author

adamlui commented Dec 15, 2024

In case you see the QR code after dismissing it, execute the given snippet at Tampermonkey's background page/service worker. It will output the internal state that remembers the dismissal.

Why are you asking an unpaid victim of your bug to edit your extension's source code, this is such a bizarre interaction

Just comment here and I'll re-open the issue if you can reproduce the QR code re-appear post-dismissal. Thanks.

I literally commented the issue has not been confirmed resolved, why are you thanking me

Not sure what you mean by that and how it relates the issue.

Well you are trying to play off your awkward instruction to log a chrome method's output (and doubling down now) suggesting you meant I should edit your extension's source code (highly unbelievable, have you ever asked a victim of your bug to edit your own extension, let alone assume userscript authors are extension authors capable of navigating crx), leading me to believe I embarassed you for exposing you didn't know such a basic fact userscripts typically cannot log chrome.storage so you pivoted to your strange story

@adamlui
Copy link
Author

adamlui commented Dec 15, 2024

How it relates is emotions like anger cloud your judgment leading to abrupt closures of unresolved issues (timing was near-simultaneous to #2298 further fueling my belief u are mad)

@derjanb
Copy link
Member

derjanb commented Dec 15, 2024

you meant I should edit your extension's source code

You can execute code in the extension context when Developer Tools are open. The link to the FAQ explains how to get there. I'm sorry again. Since you're a userscript developer, I thought you know what I mean.
I just wanted some help in debugging the issue you've encountered. No need to edit anything.
So if you see the issue again, please open the Developer Tools, select the "Console" tab and paste the JavaScript snippet at the bottom (right of the two arrows pointing to the right) and press enter. Thanks.

image

@adamlui
Copy link
Author

adamlui commented Dec 15, 2024

I absolutely know how to do this, I'm saying your statements like:

Since you're a userscript developer, I thought you know what I mean

... reveal you are awkwardly changing your story out of embarassment because they get weirder and weirder (why would a userscript dev "know what you mean", I only know because I'm a Chrome extension dev which has service workers)

@adamlui
Copy link
Author

adamlui commented Dec 15, 2024

So I made u mad because I embarassed you into looking like an incompetent programmer in your mind

@adamlui
Copy link
Author

adamlui commented Dec 15, 2024

Also it's very unbelievable given how many (true) things I exposeed about you, and the timing of your abrupt closures of unresolved issues, also the strange way you utter "thanks" as if to mask an opposite emotion even after victim already revealed they are complaining about unpaid labor so why would a thank be genuine if you even understood they don't want to work for you, like you instinctually say it to get ppl to work for you free

@7nik
Copy link

7nik commented Dec 15, 2024

The only thing I see, is that @adamlui seems unable to comprehend this:

next time if it happens I'll show a screenshot

Please check then the output of this command as well.

chrome.storage.local.get(['#misc_configglobal_hints.items'], e => console.log(e))

(Which makes me wonder whether he really can read JavaScript and even English)

Then does a bunch of false assumptions out of blue and flatulently insults @derjanb mostly for nothing.
Shame on you, @adamlui


when streaming text response from AI, TM crashes a lot of my users' browsers

As with any problem, you should open a new issue, desirably along with a reproduction script or to-do-steps.

@adamlui
Copy link
Author

adamlui commented Dec 16, 2024

@7nik I don't think you understsand the cmd he pasted does not work from userscripts. When I pointed this out, he got mad because it made him (in his mind) look oblivious to how his own extension even works (which is actually quite true, e.g. in this comment he didn't even know TM pops open new tabs for auto-updates)

i.e. he is lying he meant do it in extension env, because in the past, he made this comment:

The crx is already signed by the Chrome Webstore, but the version must be reviewed by their team before release.

Source: #2116 (comment)

Yet in current thread we're in he is trying to sell the story claiming "Sorry, I thought you were familiar with how to do this" re: CRX service worker.

So why would someone who (correctly) assumes most TM users aren't familiar with crx architecture suddenly think "I thought you were familiar" unless he were lying? It makes no sense (just like other lies he made like he didn't steal my code/idea for reading storage by passing array that are blatantly unbelievable due to timing or previous comments made)

@adamlui
Copy link
Author

adamlui commented Dec 16, 2024

@7nik it's obvious he didn't know I'm a prolific crx author by his comment "the version must be reviewed by their team before release" (anyone who publishes to CWS already knows this) so why would he now claim he thought I was familiar unless he were lying? (Then, think about why he lied, you will begin to understand)

@adamlui
Copy link
Author

adamlui commented Dec 16, 2024

Hint: it's because to support receiving continued free labor he must appear superior in at least technological prowess which if the lie is not sold, suggests is untrue due to he thought chrome method outputs work from userscript

@adamlui
Copy link
Author

adamlui commented Dec 16, 2024

@7nik how come you work for him free? Do you look up to his technical knowledge perhaps? Would you still if you thought he thought Chrome API methods are exposed thru userscript, or that he copies/steals ideas? Probably not right? Hopefully now you understand why he lied...

@7nik
Copy link

7nik commented Dec 16, 2024

the cmd he pasted does not work from userscripts

and where did he tell to execute the command in the userscript context? For me, it's obvious that the command will work only in an extension context (console). And, if you are indeed on Mozilla's Community Advisory Board as you claim, you must be familiar with at least the basics of extensions and thus the right context is obvious to you as well.


So why would someone who (correctly) assumes most TM users aren't familiar with crx architecture suddenly think "I thought you were familiar"?

You aren't a regular TM (or any other userscript manager) user knowing nothing about coding, you are an experienced userscript developer and "Community Advisory Board Member", so the chance you know the "crx architecture" quite high. Or you aren't familiar with the "crx architecture"?


@7nik how come you work for him free?

What the heck is this nonsense? What did you smoke to make up all this bs? Though, no, I don't want to know it anyway.

P.S. Don't bother to reply to me because I won't reply anyway. This issue is about problems with the QR code banner, which derjanb seems to fixed, so anything else should be discussed either in other issues or not on GitHub at all.


@derjanb I advise locking this conversation as already completely offtopic.

@adamlui
Copy link
Author

adamlui commented Dec 16, 2024

and where did he tell to execute the command in the userscript context?

He didn't say anywhere originally (he changed to his lie after my comment revealing it doesn't work from userscript)

For me, it's obvious that the command will work only in an extension context (console)

For me too, why are you telling me this? You are suggesting most userscript users understand extension context like me and you (let alone are even developers)? If so, how come?

And, if you are indeed on Mozilla's Community Advisory Board as you #2242 (comment), you must be familiar with at least the basics of extensions and thus the right context is obvious to you as well.

He made his reply before replying to that comment (and again, after a comment mansplaining what is Chrome review team so obviously assumes I don't understand extensions) also nice try trying to slander me as the liar, you really do work for him free without realizing it

image

@adamlui
Copy link
Author

adamlui commented Dec 16, 2024

You aren't a regular TM (or any other userscript manager) user knowing nothing about coding, you are an experienced userscript developer and "Community Advisory Board Member", so the chance you know the "crx architecture" quite high. Or you aren't familiar with the "crx architecture"?

Of course I am, but he already tried to mansplain it to me so obviously thought I was a noob, I don't get why this is so hard to get (he only switched up to the lie when I accidentally made him look dumb for thinking chrome is exposed in userscript)

@adamlui
Copy link
Author

adamlui commented Dec 16, 2024

I advise locking this conversation as already completely offtopic.

@7nik you are his unpaid advisor now lol? Also you realize you tagged me to argue he is not a liar (despite obviously so for switching from talking to a noob to sudden CRX expert) i.e. you are extending any off-topicness then advising an advisee to take action based on your own action...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants