Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(chat-panel): clean up chat panel api #3611

Merged
merged 6 commits into from
Dec 24, 2024
Merged

refactor(chat-panel): clean up chat panel api #3611

merged 6 commits into from
Dec 24, 2024

Conversation

icycodes
Copy link
Member

No description provided.

@icycodes icycodes marked this pull request as draft December 23, 2024 14:10
wsxiaoys
wsxiaoys reviewed Dec 23, 2024
View reviewed changes
Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few naming nits in SDK, otherwise LGTM

clients/tabby-chat-panel/src/index.ts Outdated Show resolved Hide resolved
clients/tabby-chat-panel/src/index.ts Outdated Show resolved Hide resolved
@icycodes icycodes requested a review from liangfung December 23, 2024 16:11
@icycodes icycodes marked this pull request as ready for review December 23, 2024 16:11
@wsxiaoys wsxiaoys merged commit be44c91 into TabbyML:main Dec 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsxiaoys wsxiaoys wsxiaoys approved these changes

@liangfung liangfung Awaiting requested review from liangfung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icycodes @wsxiaoys