Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace iframe src with uc-src #13

Open
vergissberlin opened this issue Aug 4, 2020 · 2 comments
Open

Replace iframe src with uc-src #13

vergissberlin opened this issue Aug 4, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@vergissberlin
Copy link

Feature Request

As described in https://docs.usercentrics.com/#/smart-data-protector?id=noscript-protection the src attribute in iframe tags should be replaced with uc-src.

Describe the solution you'd like
It would be nice to add this replacement to a render hook. Maybe with an option to enable and disable it in the extension configuration.

Describe alternatives you've considered
Otherwise I have to replace it manually for all pages and pages in the future where editors add snippets in there content.

Additional context
Editor add iframe snippets from "share link" like Youtube or Google Maps.

What you think about that!?
thx!

@NeoBlack NeoBlack added the enhancement New feature or request label Aug 5, 2020
@NeoBlack
Copy link
Member

NeoBlack commented Aug 5, 2020

nice and good idea, but I am not sure how to solve this, because not all iframes should be replaced.
This is only relevant for example youtube iframes.

@vergissberlin
Copy link
Author

vergissberlin commented Nov 17, 2020

Hi @NeoBlack,

okay, you're right. Maybe only for the fce text-media with youtube content?
image
The page render hook would be a good place OR override the fluid styled content template.

André

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants