Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible performance ramifications #3

Open
s2b opened this issue May 24, 2024 · 0 comments
Open

Possible performance ramifications #3

s2b opened this issue May 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@s2b
Copy link

s2b commented May 24, 2024

First of all, thank you for this prototype! I was thinking about possible performance issues that could arise from the implementation and wanted to leave a few thoughts here:

  • I think that there needs to be some kind of locking mechanism to make sure that only one processing task is triggered per queue entry. Maybe there's also an intelligent way to let other clients know that they should try again later or something like that?
  • I think that there should be some kind of (configurable?) limit of parallel image processing tasks to protect the server from overload. I know that this is also the case today, but now we're talking about many more parallel requests that could take some time to finish.
  • For performance reasons, it could make sense to persist the queue in another location than the database, like redis or a dedicated queueing system. Maybe that's worth looking into.

Let me know if you need further input about this.

@lukaszuznanski lukaszuznanski added the enhancement New feature or request label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants