Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Current Law Policy JSONs #125

Open
sebastiansajie opened this issue Feb 8, 2019 · 2 comments
Open

Multiple Current Law Policy JSONs #125

sebastiansajie opened this issue Feb 8, 2019 · 2 comments
Labels
question Further information is requested

Comments

@sebastiansajie
Copy link
Collaborator

@martinholmer
Is it possible to have multiple current law policy json files as these files will get really long as we include several policy paramaters? Thanks.

@sebastiansajie sebastiansajie added the question Further information is requested label Feb 8, 2019
@martinholmer
Copy link
Collaborator

@sebastiansajie asked in issue #125:

Is it possible to have multiple current_law_policy.json files as these files will get really long as we include several policy parameters?

We've never done that because it would make the source code more complex and more difficult to maintain.

Now the TPRU file has 507 lines (see screenshot below).
The USA Tax-Calculator file contains 7,040 lines and we don't have any issues.

screen shot 2019-02-10 at 12 46 14 pm

@martinholmer
Copy link
Collaborator

@sebastiansajie, Are you still hoping to have multiple files?
If so, we should discuss the pros and cons. If not, maybe you should close issue #125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants