-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dart 2.12 compatibility #2
base: main
Are you sure you want to change the base?
Conversation
Running `dart migrate` tool, accepting all changes. With this change I can get dart-junitreport to work with Dart 2.12.
See also TOPdesk/dart-junitreport#31 |
@rspilker looks like a nice pull request, making this project null-safe... could you have a look into it? Would be nice to get a null-safe release. |
@trygvis do you know if this project, after your updates, supports all of the features of the Dart tester? As in, will it correctly and fully parse every possible test report output? |
@renatoathaydes That is hard to know without having every possible test report :) I've just gotten it to work for me, it worked nicely on the few test reports I have in my Gitlab setup. The code is quite easy to work with though, so if you have found an issue it shouldn't be too hard to fix. |
So I suppose the JSON format is undocumented? |
No, it's quite well documented: https://github.com/dart-lang/test/blob/master/pkgs/test/doc/json_reporter.md |
Ah, so maintaining full compatibility looks pretty easy. |
That doc turned out to be really useful... I published a package on pub.dev that generates the model and a JSON parser automatically just from that markdown doc: https://github.com/renatoathaydes/test_report_parser.dart So hopefully, when they update the docs, all I need to do is re-run the generator and publish it again on pub.dev. @trygvis Feel free to use that instead of this package as it's kind of un-maintained from the looks of it. |
Running
dart migrate
tool, accepting all changes.With this change I can get dart-junitreport to work with Dart 2.12.
Note that this also bumps the major version to 2.0.0 which seems to be the norm for null-save libraries.