Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart 2.12 compatibility #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dart 2.12 compatibility #2

wants to merge 1 commit into from

Conversation

trygvis
Copy link

@trygvis trygvis commented Jun 2, 2021

Running dart migrate tool, accepting all changes.

With this change I can get dart-junitreport to work with Dart 2.12.

Note that this also bumps the major version to 2.0.0 which seems to be the norm for null-save libraries.

Running `dart migrate` tool, accepting all changes.

With this change I can get dart-junitreport to work with Dart 2.12.
@trygvis
Copy link
Author

trygvis commented Jun 2, 2021

See also TOPdesk/dart-junitreport#31

@renatoathaydes
Copy link

@rspilker looks like a nice pull request, making this project null-safe... could you have a look into it? Would be nice to get a null-safe release.

@renatoathaydes
Copy link

@trygvis do you know if this project, after your updates, supports all of the features of the Dart tester? As in, will it correctly and fully parse every possible test report output?

@trygvis
Copy link
Author

trygvis commented Jun 7, 2021

@renatoathaydes That is hard to know without having every possible test report :)

I've just gotten it to work for me, it worked nicely on the few test reports I have in my Gitlab setup. The code is quite easy to work with though, so if you have found an issue it shouldn't be too hard to fix.

@renatoathaydes
Copy link

That is hard to know without having every possible test report

So I suppose the JSON format is undocumented?

@trygvis
Copy link
Author

trygvis commented Jun 8, 2021

@renatoathaydes
Copy link

Ah, so maintaining full compatibility looks pretty easy.

@renatoathaydes
Copy link

That doc turned out to be really useful... I published a package on pub.dev that generates the model and a JSON parser automatically just from that markdown doc:

https://github.com/renatoathaydes/test_report_parser.dart

So hopefully, when they update the docs, all I need to do is re-run the generator and publish it again on pub.dev.

@trygvis Feel free to use that instead of this package as it's kind of un-maintained from the looks of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants