Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can PENDING bookings be cancelled? #557

Open
eborremans opened this issue Nov 8, 2024 · 0 comments · May be fixed by #564
Open

Can PENDING bookings be cancelled? #557

eborremans opened this issue Nov 8, 2024 · 0 comments · May be fixed by #564
Assignees
Milestone

Comments

@eborremans
Copy link
Collaborator

Depending on whether this is supported, the text of /bookings/{id}/events - CANCEL should read "Cancels a PENDING or CONFIRMED booking".

The current spec does not seem to be explicit about this so I guess implementers are free to implement this behavior without really violating the spec. But it would be good to make this explicit. We would like to be able to explicitly cancel PENDING bookings with long expiry times so that we can early release assets (and make the available to other users) that result from long winded interrupted booking flows.

Implementers could still be free to explicitly not support this behavior, but then this has to be reflected somehow in the cancel response (PENDING_BOOKINGS_NOT_CANCELLABLE or something). I don't think I would go as far as to have this behavior specified in a process identifier.

The quick solution would be to just update the text in the spec to read "Cancels a PENDING or CONFIRMED booking".

@edwinvandenbelt edwinvandenbelt added this to the 1.6 milestone Dec 4, 2024
@edwinvandenbelt edwinvandenbelt self-assigned this Dec 19, 2024
@edwinvandenbelt edwinvandenbelt moved this to In review in WT1 Kanban Dec 19, 2024
@edwinvandenbelt edwinvandenbelt linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging a pull request may close this issue.

2 participants