Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHANGE REQUEST] Make validUntil in the card object optional #533

Open
matt-wirtz opened this issue Feb 13, 2024 · 0 comments · Fixed by #538
Open

[CHANGE REQUEST] Make validUntil in the card object optional #533

matt-wirtz opened this issue Feb 13, 2024 · 0 comments · Fixed by #538
Assignees
@edwinvandenbelt
Labels
WT1 To be discussed at the next meeting
Milestone
1.6

Comments

@matt-wirtz
Copy link
Collaborator

API Version

1.5

Summary

The validUntil parameter is mandatory which makes sense for cards like CC. But for e.g. bank cards it usually doesn't make sense. Therefore make it optional.

Possible Solution

Make validUntil in the card object optional
@edwinvandenbelt edwinvandenbelt added the WT1 To be discussed at the next meeting label Feb 14, 2024
@edwinvandenbelt edwinvandenbelt added this to the 1.6 milestone Feb 14, 2024
@edwinvandenbelt edwinvandenbelt self-assigned this Feb 14, 2024
@edwinvandenbelt edwinvandenbelt linked a pull request Feb 14, 2024 that will close this issue
533 removed required validUntil from card object #538
Merged
@edwinvandenbelt edwinvandenbelt moved this to Done in WT1 Kanban Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edwinvandenbelt edwinvandenbelt

Labels
WT1 To be discussed at the next meeting
Projects
WT1 Kanban - old
Status: Done
Milestone
1.6
Development

Successfully merging a pull request may close this issue.

533 removed required validUntil from card object TOMP-WG/TOMP-API
2 participants
@edwinvandenbelt @matt-wirtz