-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHANGE REQUEST] Add fields like place of birth to the conditionRequireBookingData #519
Comments
Thank you Matthias! We should split this issue into several issues: |
A) Yes, placeOfBirth is used in Germany for identification issues if the person needs to be identified by authorities. And yes, would make sense to have a countryOfBirth there too. So B & D are obsolete. Should I then create separate change requests for A and C? |
So the plan is to add these fields to the required booking data:
I double checked with the customer object and added all fields that seem applicable. If these fields would not be part of the required booking data TOs could not ensure that the data is provided. So they would be more or less useless to have them in the customer object. |
I've made another (more flexible) setup in V2.0: requiredFields: |
See the last comment, we don't need to make another ticket for v2.0. This functionality is already covered by default in v2.0 (but look at the v2.0 branche for more details) |
API Version
1.5
Summary
The possible field of required booking data should be extended by:
Expected Behavior
Listed fields should be available in the conditionRequireBookingData object.
Current Behavior
Listed fields are currently not part of the conditionRequireBookingData.
Possible Solution
Add listed fields.
Mark the existing field NAME as deprecated.
The text was updated successfully, but these errors were encountered: