Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy deprecation of np.float_ #1

Open
xQiratNL opened this issue Sep 25, 2024 · 1 comment
Open

Numpy deprecation of np.float_ #1

xQiratNL opened this issue Sep 25, 2024 · 1 comment

Comments

@xQiratNL
Copy link

Hi @ThomasTNO,

I was recently using this library as an example for a course lab, but noticed that Numpy has deprecated np.float_ since reaching version 2.0.

Since numpy is not version constrained this gave an error, due to its usage here:

NumpyFloatArray = npt.NDArray[np.float_]

It should probably be fine to replace it by np.float64, which is the recommended fix, and probably you may want to restrict the numpy version :)

Steps to reproduce: install this library in a fresh environment and run one of the example.

@ThomasTNO
Copy link
Member

Hi @xQiratNL,

Thanks for noting. Internally this was fixed already. I am working on making the latest versions available asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants