Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Convert to using factory modules in lieu of a factory method in the DAG file #25

Open
jerdra opened this issue Jan 6, 2022 · 0 comments · May be fixed by #27
Open

[ENH] - Convert to using factory modules in lieu of a factory method in the DAG file #25

jerdra opened this issue Jan 6, 2022 · 0 comments · May be fixed by #27
Assignees

Comments

@jerdra
Copy link
Contributor

jerdra commented Jan 6, 2022

A meeting decision was made to shift over the scope of DAGs from specific sub-tasks to full end-to-end study DAGs. To deal with compartmentalizing sub-tasks for testability/code readability we decided on having a bunch of factory modules which construct and return an airflow TaskGroup

https://www.astronomer.io/guides/task-groups

The current datasource DAG needs to be re-written as a factory module so that a taskgroup is returned. The DAG module should only be responsible for chaining task groups.

@jerdra jerdra changed the title [ENH] - Create factory modules reading Datman config [ENH] - Convert to using factory modules in lieu of factory methods in DAG file Jan 6, 2022
@jerdra jerdra changed the title [ENH] - Convert to using factory modules in lieu of factory methods in DAG file [ENH] - Convert to using factory modules in lieu of a factory method in the DAG file Jan 6, 2022
@josephmje josephmje linked a pull request Feb 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants