Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If collect_attention = False is always False, what's the role of ar and ar2 #18

Open
Luciennnnnnn opened this issue Jul 5, 2024 · 1 comment
Open

If collect_attention = False is always False, what's the role of ar and ar2 #18

Luciennnnnnn opened this issue Jul 5, 2024 · 1 comment

Comments

@Luciennnnnnn
Copy link

Luciennnnnnn commented Jul 5, 2024 •
edited
Loading

When collect_attention = False, we always run this line, ar and ar2 do not have any effects, is this a bug?
@Luciennnnnnn Luciennnnnnn changed the title If collect_attention = False is always False， If collect_attention = False is always False, what's the role of ar and ar2 Jul 5, 2024
@yzy-thu
Copy link
Contributor

yzy-thu commented Jul 5, 2024

This is indeed a bug, thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Luciennnnnnn @yzy-thu