Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top-85 fix LocationDialog #108

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Top-85 fix LocationDialog #108

merged 2 commits into from
Sep 29, 2023

Conversation

kwangddang
Copy link
Collaborator

Explain this Pull Request 🙏

  • 한 두줄 설명

What has changed? 🤔

  • 변경 사항
    • LocationDialog 버그 수정
      • LocationDialog가 화면에 완전히 나타나기 전에, LocationDialog를 한번 더 클릭했을 때 navigation 겅로 오류 발생
      • 이미 navigation의 current가 LocationDialog면 그 외 입력들은 무시하도록 수정

Screenshot 📸

Test Checklist 🚩

@kwangddang kwangddang requested a review from cwj-c September 18, 2023 15:48
@kwangddang kwangddang self-assigned this Sep 18, 2023
cwj-c
cwj-c approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@cwj-c cwj-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!
ci 실패만 처리되고 머지되면 될 것 같아요!! 👍

@kwangddang kwangddang merged commit 1c8c30a into develop Sep 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwj-c cwj-c cwj-c approved these changes

Assignees

@kwangddang kwangddang

Labels
fix 🔎 최광현 🐱
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwangddang @cwj-c