Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onCommand sanatize #201

Open
Vam-Jam opened this issue Jun 18, 2021 · 0 comments
Open

onCommand sanatize #201

Vam-Jam opened this issue Jun 18, 2021 · 0 comments
Labels
bug Script side bug that should be fixable help wanted Help wanted with a bug/feature, may require some degree of knowledge in order to finish it

Comments

@Vam-Jam
Copy link
Collaborator

Vam-Jam commented Jun 18, 2021

Example: "shop made item" onCommand often accept any string from params (string name = params.read_string();), this can (and has) be exploited to spawn any item using 3rd party tools.

Solution:
Shop cmd should check to see if the user has actually paid for the item
Depending on the shop, have a list of 'allowed' blobs
Should log (with tcpr) who's spawned what blob with shop cmd
@Vam-Jam Vam-Jam added bug Script side bug that should be fixable help wanted Help wanted with a bug/feature, may require some degree of knowledge in order to finish it labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Script side bug that should be fixable help wanted Help wanted with a bug/feature, may require some degree of knowledge in order to finish it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vam-Jam