Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@type of <ab> gets dropped #723

Open
sydb opened this issue Dec 22, 2024 · 1 comment
Open

@type of <ab> gets dropped #723

sydb opened this issue Dec 22, 2024 · 1 comment
Labels
conversion: html
Milestone
Release 7.58.0

Comments

@sydb
Copy link
Member

sydb commented Dec 22, 2024

Using the current dev branch, I ran bin/teitohtml on a document that had an <ab type="duckling">. I was not surprised that the <tei:ab> was transformed into an <html:div>. I was surprised that the @type was dropped. It should (along with @subtype) be transformed into a @class IMHO.
@sydb sydb added this to the Release 7.58.0 milestone Dec 22, 2024
sydb added a commit that referenced this issue Dec 29, 2024
@sydb
Fix #723:
1ac70d2 
Added a small conditional block to the template that matches
the ab element that converts type= and subtype= to class=,
if they are present. This is not, IMHO, the rigth way to do
this, but it better matches the rest of the Stylesheets.
@sydb sydb mentioned this issue Dec 29, 2024
Open
@sydb
Copy link
Member Author

sydb commented Dec 29, 2024

See #724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conversion: html
Projects
None yet
Milestone
Release 7.58.0
Development

No branches or pull requests
1 participant
@sydb