#71 [feat] 디자이너 메인 뷰 기능 구현 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 10, 2024 15:27
…into feat/#71 # Conflicts: # src/main/java/com/moddy/server/controller/designer/DesignerController.java # src/main/java/com/moddy/server/domain/hair_model_application/repository/HairModelApplicationJpaRepository.java # src/main/java/com/moddy/server/service/designer/DesignerService.java
…into feat/#71 # Conflicts: # src/main/java/com/moddy/server/common/exception/enums/SuccessCode.java # src/main/java/com/moddy/server/service/designer/DesignerService.java
KWY0218
reviewed
Jan 10, 2024
Comment on lines
12
to
13
|
|
||
| List<HairModelApplicationResponse> applications |
| String name, | ||
| int age, | ||
| String imgUrl, | ||
| String gender, |
There was a problem hiding this comment.
p1
enum 클래스 내부에 있는 함수 때문에 Gender enum 을 그대로 사용해도 잘 들어옵니다!
| @Transactional | ||
| public DesignerMainResponse getDesignerMainView(Long userId, int page, int size){ | ||
| //designer | ||
| User user = designerJpaRepository.findById(userId).orElseThrow(() -> new NotFoundException(ErrorCode.USER_NOT_FOUND_EXCEPTION)); |
There was a problem hiding this comment.
p2
혹시 Designer 말고 User로 정의한 이유가 있을까요?
Designer로 정의해도 작동할 것 같습니다!
Comment on lines
24
to
28
| public Integer calAge(String year){ | ||
| LocalDateTime currentDateTime = LocalDateTime.now(); | ||
| Integer age = currentDateTime.getYear() - Integer.parseInt(year) + 1 ; | ||
| return age; | ||
| } |
There was a problem hiding this comment.
p2
해당 로직을 service에 만드는 것이 아닌 User class에 getAge 메서드를 만드는 것이 좋을 것 같습니다!
added 2 commits
January 11, 2024 01:18
…into feat/#71 # Conflicts: # src/main/java/com/moddy/server/common/exception/enums/SuccessCode.java # src/main/java/com/moddy/server/domain/model/Model.java # src/main/java/com/moddy/server/service/designer/DesignerService.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈번호
해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?