#47 [feat] 디자이너 회원가입 기능 구현 #63

pkl0912 · 2024-01-09T14:13:11Z

해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)

2일...

해결하려는 문제가 무엇인가요?

디자이너 회원가입 기능 구현..

어떻게 해결했나요?

designer - user 같은 테이블은 builder 를 superbuilder 로 설정해줘야 하고, inheritance 를 설정해줘야 한다
string으로 hairShop, portfolio 속성값들을 각각 받아서 servcie 에서 묶어서 저장 (multipart/form-data는 embeddable 객체 안됨)
controller 에서 request앞에는 ModelAttribute 속성으로 설정해준다

…into feat/#47

…into feat/#47 # Conflicts: # src/main/java/com/moddy/server/common/exception/enums/ErrorCode.java # src/main/java/com/moddy/server/common/exception/enums/SuccessCode.java # src/main/java/com/moddy/server/controller/auth/dto/request/SocialLoginRequest.java # src/main/java/com/moddy/server/domain/designer/Designer.java # src/main/java/com/moddy/server/domain/designer/HairShop.java # src/main/java/com/moddy/server/domain/user/User.java

…into feat/#47

KWY0218

작업하시느라 고생하셨습니다!
코맨트 확인해주세요!!

KWY0218 · 2024-01-09T14:14:45Z

src/main/java/com/moddy/server/common/exception/enums/ErrorCode.java

+    INVALID_DAY_OF_WEEK_EXCEPTION(HttpStatus.NOT_FOUND, "요일을 찾을 수 없습니다"),
+    INVALID_GENDER_EXCEPTION(HttpStatus.NOT_FOUND, "성별을 찾을 수 없습니다"),


p2
해당 에러는 클라이언트가 속성 값을 잘못 입력했을 때 생기는 에러이기 때문에
BAD_REQUEST , 400 에러인 것 같습니다!

+) 제가 전에 404라고 한 것 같은데, 400이 맞는 것 같습니다 하하..

KWY0218 · 2024-01-09T14:16:45Z

src/main/java/com/moddy/server/controller/designer/DesignerController.java

+    @SecurityRequirement(name = "JWT Auth")
+    @PostMapping(value = "/designer", consumes = {MediaType.APPLICATION_JSON_VALUE, MediaType.MULTIPART_FORM_DATA_VALUE})
+    SuccessResponse<DesignerCreateResponse> createDesigner(@Parameter(hidden = true) @KakaoCode String kakaoCode, @ModelAttribute DesignerCreateRequest request) {
+        System.out.println(request);


p1
println은 지워주세요!

KWY0218 · 2024-01-09T14:17:21Z

src/main/java/com/moddy/server/controller/designer/dto/request/DesignerCreateRequest.java

+
+        String instagramUrl,
+        String naverPlaceUrl,
+


p2
불필요한 공백을 지워주세요!

KWY0218 · 2024-01-09T14:17:58Z

src/main/java/com/moddy/server/domain/day_off/DayOff.java

-public class DayOff extends BaseTimeEntity {
+public class DayOff{


p1
base entity 를 제거하면 안됩니다..!

KWY0218 · 2024-01-09T14:19:05Z

src/main/java/com/moddy/server/service/DesignerService.java

+
+//        String kakaoId = String.valueOf(kakaoSocialService.login(SocialLoginRequest.of(code)));


p1
불필요한 주석은 제거해주세요!

KWY0218 · 2024-01-09T14:19:50Z

src/main/java/com/moddy/server/service/DesignerService.java

+
+
+
+


p2
불필요한 공백은 제거해주세요

KWY0218 · 2024-01-09T14:22:12Z

src/main/java/com/moddy/server/domain/user/User.java

+    public User(String kakaoId, String name, Gender gender, String phoneNumber,  Boolean isMarketingAgree, String profileImgUrl ) {
+        this.kakaoId = kakaoId;
+        this.name = name;
+        this.gender = gender;
+        this.phoneNumber = phoneNumber;
+        this.isMarketingAgree = isMarketingAgree;
+        this.profileImgUrl = profileImgUrl;
+        this.role = role;
+    }
+


p2
사용하지 않은 생성자인 듯 합니다! 제거해주세요!

KWY0218 · 2024-01-09T14:22:37Z

src/main/java/com/moddy/server/service/DesignerService.java

+@Transactional(readOnly = true)
+@Builder


p1
불필요한 어노테이션으로 보입니다.

KWY0218 · 2024-01-09T14:47:37Z

src/main/java/com/moddy/server/domain/user/Gender.java

+                .findFirst()
+                .orElseThrow(() -> new BadRequestException(ErrorCode.INVALID_DAY_OF_WEEK_EXCEPTION));
+    }


p2
DAY_OF_WEEK_EXCEPTION이 아닌 INVALID_GENDER_EXCEPTION인 것 같습니다!

KWY0218 · 2024-01-09T14:48:12Z

src/main/java/com/moddy/server/domain/day_off/DayOfWeek.java

 @Getter
 @AllArgsConstructor
 public enum DayOfWeek {
    NOTHING("없음"), MON("월"), TUE("화"), WED("수"), THU("목"), FRI("금"), SAT("토"), SUN("일");

    private final String value;
+
+    @JsonCreator(mode = JsonCreator.Mode.DELEGATING)
+    public static DayOfWeek findByDay(String dayOfWeek) {


p4
findByDayOfWeek는 어떨까요..?

KWY0218

작업하시느라 고생하셨습니다!

hellozo0

수고하셨습니다~~! 로직이 좋네요... 갓경린...

hellozo0 · 2024-01-09T15:18:39Z

src/main/java/com/moddy/server/common/exception/enums/ErrorCode.java

@@ -23,6 +25,7 @@ public enum ErrorCode {
    USER_NOT_FOUND_EXCEPTION(HttpStatus.NOT_FOUND, "해당 유저는 존재하지 않습니다."),

    // 405 METHOD_NOT_ALLOWED
+


p4 :
위의 에러코드들 처럼 ErrorCode 주석 아래 공백 지우면 좋을것 같아요!

hellozo0 · 2024-01-09T15:19:03Z

src/main/java/com/moddy/server/common/exception/enums/SuccessCode.java

@@ -8,10 +8,13 @@
 @AllArgsConstructor
 public enum SuccessCode {

+


p4:
여기도 공백 지우면 좋을 것 같아요!

hellozo0 · 2024-01-09T15:19:07Z

src/main/java/com/moddy/server/common/exception/enums/SuccessCode.java

    FIND_MODEL_MAIN_INFO_SUCCESS(HttpStatus.OK, "모델 메인 뷰 조회 성공"),
    SOCIAL_LOGIN_SUCCESS(HttpStatus.OK, "카카오 로그인 성공입니다."),
    USER_MY_PAGE_SUCCESS(HttpStatus.OK, "마이페이지 유저 정보 조회 성공입니다.");

+


p4:
여기도 공백 지우면 좋을 것 같아요!

hellozo0 · 2024-01-09T15:24:48Z

src/main/java/com/moddy/server/domain/user/Gender.java

+
+    @JsonCreator(mode = JsonCreator.Mode.DELEGATING)
+    public static Gender findByGender(String gender) {
+        return Stream.of(Gender.values())
+                .filter(c -> c.getValue().equals(gender))
+                .findFirst()
+                .orElseThrow(() -> new BadRequestException(ErrorCode.INVALID_GENDER_EXCEPTION));
+    }


find 메소드 좋네요! 감사합니다...

hellozo0 · 2024-01-09T15:25:09Z

src/main/java/com/moddy/server/service/DesignerService.java

+        request.dayOffs().stream()
+                .forEach(d -> {
+                    DayOff dayOff = DayOff.builder()
+                            .dayOfWeek(d)
+                            .designer(designer)
+                            .build();
+                    dayOffJpaRepository.save(dayOff);
+
+                });


dayoff 사용법도 확인했습니다!

pkl0912 added 15 commits January 8, 2024 18:45

#47 [feat] 디자이너 request 구현

684e066

Merge branch 'develop' of https://github.com/TEAM-MODDY/moddy-server …

ec51145

…into feat/#47

#47 [feat] designer class & dto 구현

136674d

#47 [fix] designer buidler 수정

93cde86

Merge branch 'develop' of https://github.com/TEAM-MODDY/moddy-server …

f6cd102

…into feat/#47

#47 [feat] 에러 코드, 회원가입 성공 코드 작성

02ba3a4

#47 [feat] request 객체 구현

f5acee3

#47 [feat] response 객체 작성

de2ada0

#47 [feat] post controller 작성

d4b3c25

#47 [feat] 도메인 작성

09a2ba1

#47 [feat] service 구현

9ae1614

#47 [refactor] basetimeEntity 수정

de83404

Merge branch 'develop' of https://github.com/TEAM-MODDY/moddy-server …

203304a

…into feat/#47

#47 [feat] 디자이너 회원가입 기능 구현

4418462

pkl0912 added the feat label Jan 9, 2024

pkl0912 requested review from hellozo0 and KWY0218 January 9, 2024 14:13

pkl0912 self-assigned this Jan 9, 2024

KWY0218 requested changes Jan 9, 2024

View reviewed changes

#47 [refactor] 불필요한 코드 삭제 및 수정

96c798a

KWY0218 reviewed Jan 9, 2024

View reviewed changes

#47 [refactor] 코드 수정

7fcf823

KWY0218 approved these changes Jan 9, 2024

View reviewed changes

hellozo0 approved these changes Jan 9, 2024

View reviewed changes

#47 [refactor] 공백 수정

cce504c

pkl0912 merged commit 8469443 into develop Jan 9, 2024
1 check passed

pkl0912 deleted the feat/#47 branch January 9, 2024 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#47 [feat] 디자이너 회원가입 기능 구현 #63

#47 [feat] 디자이너 회원가입 기능 구현 #63

pkl0912 commented Jan 9, 2024

KWY0218 left a comment

KWY0218 Jan 9, 2024

KWY0218 Jan 9, 2024

KWY0218 Jan 9, 2024

KWY0218 Jan 9, 2024

KWY0218 Jan 9, 2024

KWY0218 Jan 9, 2024

KWY0218 Jan 9, 2024

KWY0218 Jan 9, 2024

KWY0218 Jan 9, 2024

KWY0218 Jan 9, 2024

KWY0218 left a comment

hellozo0 left a comment

hellozo0 Jan 9, 2024

hellozo0 Jan 9, 2024

hellozo0 Jan 9, 2024

hellozo0 Jan 9, 2024

hellozo0 Jan 9, 2024

		INVALID_DAY_OF_WEEK_EXCEPTION(HttpStatus.NOT_FOUND, "요일을 찾을 수 없습니다"),
		INVALID_GENDER_EXCEPTION(HttpStatus.NOT_FOUND, "성별을 찾을 수 없습니다"),

		public class DayOff extends BaseTimeEntity {
		public class DayOff{


		// String kakaoId = String.valueOf(kakaoSocialService.login(SocialLoginRequest.of(code)));

		@@ -23,6 +25,7 @@ public enum ErrorCode {
		USER_NOT_FOUND_EXCEPTION(HttpStatus.NOT_FOUND, "해당 유저는 존재하지 않습니다."),

		// 405 METHOD_NOT_ALLOWED

		@@ -8,10 +8,13 @@
		@AllArgsConstructor
		public enum SuccessCode {

		@Transactional(readOnly = true)
		@Builder

#47 [feat] 디자이너 회원가입 기능 구현 #63

#47 [feat] 디자이너 회원가입 기능 구현 #63

Conversation

pkl0912 commented Jan 9, 2024

관련 이슈번호

해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)

해결하려는 문제가 무엇인가요?

어떻게 해결했나요?

KWY0218 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KWY0218 left a comment

Choose a reason for hiding this comment

hellozo0 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment