#233 [fix] 지원서 다운로드 URL 생성 API 수정 #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellozo0
approved these changes
Feb 16, 2024
| @ApiResponse(responseCode = "404", description = "해당 지원서는 존재하지 않습니다.", content = @Content(schema = @Schema(implementation = ErrorResponse.class))), | ||
| @ApiResponse(responseCode = "500", description = "서버 내부 오류 입니다.", content = @Content(schema = @Schema(implementation = ErrorResponse.class))), | ||
| }) | ||
| @GetMapping("/{applicationId}/download-url") |
| @Parameter(hidden = true) @UserId final Long modelId, | ||
| @PathVariable final Long applicationId | ||
| ) { | ||
| return SuccessResponse.success(GET_PRE_SIGNED_URL_SUCCESS, hairModelApplicationRetrieveService.getApplicationCaptureDownloadUrl(applicationId)); |
There was a problem hiding this comment.
이부분에서 "디자이너 제안 상세보기 API에서 주는 applicationId를 사용해야 함" --> 해당 service 불러오기 확인했습니다!
Comment on lines
+121
to
+127
| public DownloadUrlResponseDto getApplicationCaptureDownloadUrl(final Long applicationId) { | ||
| final HairModelApplication hairModelApplication = hairModelApplicationJpaRepository.findById(applicationId) | ||
| .orElseThrow(() -> new NotFoundException(ErrorCode.NOT_FOUND_APPLICATION_EXCEPTION)); | ||
| final String applicationDownloadUrl = s3Service.getPreSignedUrlToDownload(hairModelApplication.getApplicationCaptureUrl()); | ||
| return new DownloadUrlResponseDto(applicationDownloadUrl); | ||
| } | ||
|
|
There was a problem hiding this comment.
해당 지원서 아이디로 지원서 정보 조회하고 url정보 가져오는것 확인했습니다!
…into feat/#233 # Conflicts: # src/main/java/com/moddy/server/controller/application/ApplicationRetrieveController.java # src/main/java/com/moddy/server/controller/designer/DesignerRegisterController.java # src/main/java/com/moddy/server/service/application/HairModelApplicationRetrieveService.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈번호
해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?