Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Task 타임블로킹 수정 api 연결 #221

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

Kjiw0n
Copy link
Contributor

@Kjiw0n Kjiw0n commented Jul 18, 2024

작업 내용 🧑‍💻

  • Task 타임블로킹 수정 api 연결
  • fullcalendar에서 re드래그 시, 이미 생성된 timeblock의 위치 옮길 시의 이벤트를 감지하여 api 실행되도록 구현

알게된 점 🚀

기록하며 개발하기!

  • fullcalendar에서 re드래그 시, 이미 생성된 timeblock의 위치 옮길 시의 이벤트를 감지할 수 있음을 알았습니다. 라이브러리의 소중함을 다시 깨달았습니다.

리뷰 요구사항 💬

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • 수정이 된 후 딜레이가 있습니다. 이 부분 참고해주세요.

관련 이슈

close #215

스크린샷 (선택)

Jul-19-2024 06-51-14

Copy link
Member

@wrryu09 wrryu09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 잘 되는 거 확인했습니다! 확실히 수정할 때마다 데이터를 새로 불러오다 보니 딜레이가 심하네요,,
상태를 더 효과적으로 관리할 수 있는 방법을 찾아보겠습니다..

@@ -0,0 +1,6 @@
export interface PatchTimeBlokType {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오타낫서요

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

레전드 오타발견녀

@@ -28,25 +29,41 @@ interface FullCalendarBoxProps {

function FullCalendarBox({ size, selectDate, selectedTarget }: FullCalendarBoxProps) {
const today = new Date().toDateString();
const todayDate = new Date().toISOString().split('T')[0];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 포맷 맞출 수도 있군요!!


mutate({ taskId: selectedTarget.id, startTime: startStr, endTime: endStr });
updateMutate({ taskId, timeBlockId, startTime: startStr, endTime: endStr });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 또는 usePatchTimeBlock 안에서 taskId 가 -1인 경우 (구캘인 경우) update 막으면 될 것 같습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 반영해주셨네요 감사합니다 ㅎㅎㅎㅎ

Copy link
Member

@jeeminyi jeeminyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다! 잘 보았습니다

@@ -1,10 +1,10 @@
import styled from '@emotion/styled';
import { ViewMountArg, DatesSetArg, EventClickArg } from '@fullcalendar/core';
import { ViewMountArg, DatesSetArg, EventClickArg, EventDropArg } from '@fullcalendar/core';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

풀캘린더코어

Copy link
Member

@seong-hui seong-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 부분을 낙관적 업데이트를 어떻게 진행할지 생각을 해봐야겠네요!! 해당 부분 구현하시느라 고생 많으셨습니다 👍

@Kjiw0n Kjiw0n force-pushed the feat/#215-update-timeblock-api branch from d76a170 to c585e76 Compare July 19, 2024 06:22
@Kjiw0n Kjiw0n merged commit 4444de0 into develop Jul 19, 2024
2 checks passed
@Kjiw0n Kjiw0n deleted the feat/#215-update-timeblock-api branch July 19, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEAT] Task 타임블로킹 수정 api 연결
4 participants