[FEAT] Task 리스트 조회 api 연결 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeminyi
approved these changes
Jul 17, 2024
Comment on lines
+6
to
+11
| /** Task 리스트 조회 */ | ||
| const useGetTasks = ({ isTotal, sortOrder, targetDate }: GetTasksType) => | ||
| useQuery({ | ||
| queryKey: ['today', isTotal, sortOrder, targetDate], | ||
| queryFn: () => getTasks({ isTotal, sortOrder, targetDate }), | ||
| }); |
There was a problem hiding this comment.
요런 식으로 리액트 쿼리를 사용하는 거군요,, 처음 써보기에 좀 막막한데요오 먼저 잘 정리해주셔서 잘 참고할 수 있을 것 같습니다!
쿼리키에 today를 추가해주신 이유는 무엇인가요? 오늘 날짜를 기준으로 순서를 sort 하기 위함인가용?-?
There was a problem hiding this comment.
today 페이지에서 사용해서 페이지별로 구분하면 이해하기 빠를 것 같아서 앞에 써주었습니다! 소팅하는 건 getTasks로 전달하는 요소들 중 두번째에서 담당하고 있어요!
| const { data } = await privateInstance.get('/api/tasks', { | ||
| params: { | ||
| isTotal, | ||
| order: sortOrder, |
There was a problem hiding this comment.
요건 걍 궁금한건데 order는 왜 sortOrder로 한번 더 명명해준건가용??
There was a problem hiding this comment.
state 이름을 order로 지으면 구분하기가 다소 모호한데 서버에서 요구하는 path variable 에서는 order로 명명되어 있어서 한번 바꿔서 전달해줬습니다!
Kjiw0n
approved these changes
Jul 17, 2024
| CLOSEST: '지연된 할 일', | ||
| CLOSEST: '가까운 마감기한순', |
Comment on lines
35
to
46
| // const dummyTaskList: TaskType[] = [ | ||
| // { | ||
| // id: 3, | ||
| // name: '김지원', | ||
| // deadLine: { | ||
| // date: '2024-06-30', | ||
| // time: '12:30', | ||
| // }, | ||
| // hasDescription: true, | ||
| // status: '미완료', | ||
| // }, | ||
| // ]; |
wrryu09
force-pushed
the
feat/#165/get-task-api
branch
from
e623d73 to
050593f
Compare
seong-hui
reviewed
Jul 17, 2024
There was a problem hiding this comment.
구글 버튼을 따로 분리해주셨군요! 해당 파일을 분리하는 게 더 보기 좋아보이네요 감사합니다!
| import { Navigate, Outlet } from 'react-router-dom'; | ||
|
|
||
| function PrivateRoute() { | ||
| const isAuthenticated = localStorage.getItem('accessToken'); |
There was a problem hiding this comment.
해당 부분은 나중에 맞는 accesstoken인지 교차검증을 하는 과정을 추가하도록 하겠씁니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 🧑💻
알게된 점 🚀
리뷰 요구사항 💬
관련 이슈
close #165
스크린샷 (선택)