Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files into new directories #104

Open
bishtgautam opened this issue Oct 16, 2020 · 2 comments
Open

Move files into new directories #104

bishtgautam opened this issue Oct 16, 2020 · 2 comments
Labels
cleanup Refactor code

Comments

@bishtgautam
Copy link
Member

Current directory structure:

ls -l src
total 480
drwxr-xr-x  4 bish218  PNL\Domain Users    128 Oct 16 10:51 f90-mod
drwxr-xr-x  3 bish218  PNL\Domain Users     96 Sep 11  2019 interface
drwxr-xr-x  4 bish218  PNL\Domain Users    128 Oct 16 10:51 mesh
drwxr-xr-x  6 bish218  PNL\Domain Users    192 Oct 13 22:33 mpfao
-rw-r--r--  1 bish218  PNL\Domain Users  26424 Oct 13 22:32 tdybdm.c
-rw-r--r--  1 bish218  PNL\Domain Users  48381 Oct 16 10:51 tdycore.c
-rw-r--r--@ 1 bish218  PNL\Domain Users    776 Sep 16  2019 tdydebug.c
-rw-r--r--  1 bish218  PNL\Domain Users   7029 Oct 16 10:51 tdydm.c
-rw-r--r--  1 bish218  PNL\Domain Users   5710 Oct 16 10:51 tdydriver.c
-rw-r--r--  1 bish218  PNL\Domain Users   3409 Oct  5 09:10 tdyeos.c
-rw-r--r--  1 bish218  PNL\Domain Users   3858 Oct 13 22:32 tdyio.c
-rw-r--r--@ 1 bish218  PNL\Domain Users   9116 Jun 30 18:04 tdymemory.c
-rw-r--r--  1 bish218  PNL\Domain Users   7233 Oct 16 10:51 tdypermeability.c
-rw-r--r--  1 bish218  PNL\Domain Users   1886 Oct  5 09:10 tdyporosity.c
-rw-r--r--  1 bish218  PNL\Domain Users   9370 Oct 16 10:51 tdyregression.c
-rw-r--r--  1 bish218  PNL\Domain Users   3208 Oct 16 10:51 tdyrichards.c
-rw-r--r--  1 bish218  PNL\Domain Users   1388 Oct 16 10:51 tdyrockproperties.c
-rw-r--r--  1 bish218  PNL\Domain Users   5331 Aug  5 08:59 tdysaturation.c
-rw-r--r--  1 bish218  PNL\Domain Users   4123 Oct 16 10:51 tdyth.c
-rw-r--r--  1 bish218  PNL\Domain Users   5214 Oct 16 10:51 tdyti.c
-rw-r--r--  1 bish218  PNL\Domain Users  10376 Oct 13 22:32 tdytpf.c
-rw-r--r--  1 bish218  PNL\Domain Users  17983 Oct 16 10:51 tdyutils.c
-rw-r--r--  1 bish218  PNL\Domain Users  35491 Oct 12 11:46 tdywy.c

Create new directories and move most .c in new directories. Proposed new directories:

  • src/mode
  • src/misc
  • src/method
  • src/io
  • src/constitutive_model (Probably needs a better name)
proposed dir structure
f90-mod src/f90-mod
interface src/interface
mesh src/mesh
mpfao src/method
tdybdm.c src/method
tdycore.c src
tdydebug.c src/misc
tdydm.c src/method
tdydriver.c src
tdyeos.c src/constitutive_model
tdyio.c src/io
tdymemory.c src/misc
tdypermeability.c src/constitutive_model
tdyporosity.c src/constitutive_model
tdyregression.c src/misc
tdyrichards.c src/mode
tdyrockproperties.c src/constitutive_model
tdysaturation.c src/constitutive_model
tdyth.c src/mode
tdyti.c src/method
tdytpf.c src/method
tdyutils.c src/misc
tdywy.c src/method
@bishtgautam bishtgautam added the cleanup Refactor code label Oct 16, 2020
@jeff-cohere
Copy link
Collaborator

Iis there a guiding principle for this directory structure? The way it's organized now seems to encourage me to think about one of several areas of technical activity at a time when I'm working, like "a method" or "a mode/set of equations", or "I/O". Is that the idea? Or are you just trying to decrease the number of files per folder?

I'm just asking out of curiosity. Lots of teams do things with this organizational structure. I guess I'm just asking if this structure reflects the way you think about things when you work.

@jeff-cohere
Copy link
Collaborator

@bishtgautam , can we close this one? We've introduced a new directory structure as of #315 that breaks things up along the lines of the refactor. I think it reflects the structure of the code now, particularly because it lets our different subteams work in separate places, while using common elements. We can always revisit if we need to improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactor code
Projects
None yet
Development

No branches or pull requests

2 participants