Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead code in in.Actions #3130

Closed
matt2e opened this issue Oct 15, 2024 · 0 comments · Fixed by #3226
Closed

Dead code in in.Actions #3130

matt2e opened this issue Oct 15, 2024 · 0 comments · Fixed by #3226
Assignees
Labels

Comments

@matt2e
Copy link
Collaborator

matt2e commented Oct 15, 2024

In VerifySchema and VerifySchemaVerb we have:

if err != nil {
	t.Errorf("failed to get schema: %v", err)
	return
}
if err != nil { // IMPOSSIBLE
	t.Errorf("failed to deserialize schema: %v", err)
	return
}

Probably a refactor gone wrong...

@github-actions github-actions bot added the triage Issue needs triaging label Oct 15, 2024
@ftl-robot ftl-robot mentioned this issue Oct 15, 2024
@alecthomas alecthomas added the P3 label Oct 28, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Oct 28, 2024
@matt2e matt2e closed this as completed in 3d37c4a Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants