Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy provisioner to dev environment with cloudformation plugin #3117

Closed
jvmakine opened this issue Oct 14, 2024 · 0 comments · Fixed by #3334
Closed

Deploy provisioner to dev environment with cloudformation plugin #3117

jvmakine opened this issue Oct 14, 2024 · 0 comments · Fixed by #3334
Assignees
@jvmakine

Comments

@jvmakine
Copy link
Contributor

We should enable the ftl-provisioner in the dev environment, deployed with the ftl-cloudformation-plugin, and establish connectivity to that from ftl deploy to create databases in the dev environment
@github-actions github-actions bot added the triage Issue needs triaging label Oct 14, 2024
@ftl-robot ftl-robot mentioned this issue Oct 14, 2024
Open
@jvmakine jvmakine self-assigned this Oct 15, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Oct 15, 2024
@jvmakine jvmakine mentioned this issue Nov 6, 2024
Merged
jvmakine added a commit that referenced this issue Nov 6, 2024
@jvmakine @github-actions
feat: Create psql DB in the CF provisioner (#3334)
e4b72b5 
Connects to the freshly created psql instance, and creates a database if
it does not exist.

This closes #3117 with
tbdeng/ftl-aws#35

We should refactor the DB creation from the success step to be part of
the actual provisioning flow. Thicket for this:
#3333

We should also not use the root credentials when connecting to the DB
from a module. However, we should change this when looking at DB
migrations, when we won't expect modules to execute DDL anymore.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvmakine jvmakine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Create psql DB in the CF provisioner TBD54566975/ftl
1 participant
@jvmakine