Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs should include span/trace IDs in JSON #3105

Closed
stuartwdouglas opened this issue Oct 14, 2024 · 0 comments · Fixed by #3107
Closed

Logs should include span/trace IDs in JSON #3105

stuartwdouglas opened this issue Oct 14, 2024 · 0 comments · Fixed by #3107
Assignees
@stuartwdouglas

Comments

@stuartwdouglas
Copy link
Collaborator

If we include this info in the correct format then we should be able to correlate log messages to traces in the DD console
@github-actions github-actions bot added the triage Issue needs triaging label Oct 14, 2024
@ftl-robot ftl-robot mentioned this issue Oct 14, 2024
Open
@stuartwdouglas stuartwdouglas mentioned this issue Oct 14, 2024
Merged
@alec-brooks alec-brooks removed the triage Issue needs triaging label Oct 14, 2024
stuartwdouglas added a commit that referenced this issue Oct 15, 2024
@stuartwdouglas @github-actions
feat: add DD trace id to the logs (#3107)
097415d 
Only works for the go runtime at the moment, as the JVM logging needs to
be cleaned up to match the go format.

fixes: #3105

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartwdouglas stuartwdouglas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add DD trace id to the logs TBD54566975/ftl
2 participants
@stuartwdouglas @alec-brooks