Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce artifact discovery overhead #3076

Closed
jonathanj-square opened this issue Oct 10, 2024 · 0 comments · Fixed by #3184
Closed

Reduce artifact discovery overhead #3076

jonathanj-square opened this issue Oct 10, 2024 · 0 comments · Fixed by #3184
Assignees
@jonathanj-square

Comments

@jonathanj-square
Copy link
Contributor

jonathanj-square commented Oct 10, 2024 •
edited
Loading

Motivated by this comment:
#2989 (comment)

The current approach involves iterating over repositories in a registry. This is identified by Stuart as being unscalable and slow in general. Instead access into the repository should be key driven. This may require some rethinking of how components in a release such as module compilation artifacts (single binary for Go, multiple jars for JVM), schemes, etc get linked together.
@jonathanj-square jonathanj-square added the triage Issue needs triaging label Oct 10, 2024
@ftl-robot ftl-robot mentioned this issue Oct 10, 2024
Open
@jonathanj-square jonathanj-square mentioned this issue Oct 10, 2024
Merged
@wesbillman wesbillman removed the triage Issue needs triaging label Oct 10, 2024
@wesbillman wesbillman added the next Work that will be be picked up next label Oct 10, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Oct 10, 2024
@jonathanj-square jonathanj-square mentioned this issue Oct 24, 2024
Merged
jonathanj-square added a commit that referenced this issue Oct 28, 2024
@jonathanj-square @github-actions
feat: emit module artifacts as blobs (#3184)
c74b989 
fixes #3076

module binaries now stored as blobs (instead of images); enumeration
operations dropped due to inefficiency - deployment workflows do not
need it anyways

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanj-square jonathanj-square

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: emit module artifacts as blobs TBD54566975/ftl
2 participants
@wesbillman @jonathanj-square