Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "HTTP/1.1 301 Moved Permanently" failures and replaced deprecated modules. #68

Open
kaladay opened this issue Jan 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kaladay
Copy link
Contributor

kaladay commented Jan 30, 2024

In our local environment, valid "HTTP/1.1 301 Moved Permanently" responses are returned.
These are being treated as errors.

As an example, a request to http://localhost:9001/workflow/triggers might get redirected to http://localhost:9001/workflow/triggers/.

This needs to be supported.

Either add a way to automatically append a / or properly handle the permanent (or temporary) redirect.

The uuid module needs to be upgraded to at least a 7.0.0 version and must be manually added as a direct dependency.

This seems to have worked but there are problems when talking to mod-workflow:

Yarn documents that the following is a stub and should not be directly included:
"@types/commander": "2.12.2",

Changing to Spring Boot 3 results in the redirects going away (but the lack of redirect support in fw-cli still exists even if mod-workflow is not using redirects for / ending paths).

@kaladay kaladay self-assigned this Jan 30, 2024
@kaladay kaladay added the bug Something isn't working label Jan 30, 2024
@kaladay kaladay added this to FOLIO Jan 30, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in FOLIO Jan 30, 2024
@kaladay kaladay moved this from 📋 Backlog to 🏃 On Sprint in FOLIO Jan 30, 2024
@kaladay kaladay linked a pull request Jan 30, 2024 that will close this issue
@kaladay kaladay changed the title Fix "HTTP/1.1 301 Moved Permanently" failures. Fix "HTTP/1.1 301 Moved Permanently" failures and replaced deprecated modules. Feb 1, 2024
@kaladay kaladay removed their assignment Feb 1, 2024
@jeremythuff jeremythuff moved this from 🏃 On Sprint to 📋 Backlog in FOLIO Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

1 participant