Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate options for Major and ORCID in disable column section #82

Open
devangm opened this issue Jul 10, 2024 · 1 comment · Fixed by #88
Open

Duplicate options for Major and ORCID in disable column section #82

devangm opened this issue Jul 10, 2024 · 1 comment · Fixed by #88
Assignees
Labels

Comments

@devangm
Copy link

devangm commented Jul 10, 2024

To Reproduce
Steps to reproduce the behavior:

Go to 'admin/list'
Click on 'Customize columns'
Scroll down in the Disabled Columns section
See duplicates options for Major and ORCID

Image

@qtamu qtamu added the bug label Jul 12, 2024
@wwelling wwelling assigned wwelling and unassigned wwelling Jul 12, 2024
@wwelling
Copy link

wwelling commented Jul 15, 2024

The SubmissionListColumn entity table has a combined unique constraint of "title", "predicate", "input_type_id".

There are two issues:

  1. the modals for selecting submission list columns or custom filters has unidentifiable duplicate titles
  2. the multi-column sort in the admin submission list view has a bug as it is using submission column title as a unique property

A simple solution would be to make title a unique constraint. This would correct all known bugs regarding.

A more versatile solution would be to provide the predicate in the label for the submission list column such as ORCID (dc.creator.orcid). This would require fixing the bug in the multi-column sort to utilize the combined label for uniqueness. Would still have edge cases to where title and predicate are unique with a different input_type_id.

@wwelling wwelling self-assigned this Jul 15, 2024
@wwelling wwelling linked a pull request Jul 15, 2024 that will close this issue
@wwelling wwelling mentioned this issue Jul 19, 2024
@wwelling wwelling mentioned this issue Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants