Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening, Closing, and Re-opening "More..." link on facet problem. #525

Open
kaladay opened this issue Feb 8, 2023 · 0 comments · Fixed by #526
Open

Opening, Closing, and Re-opening "More..." link on facet problem. #525

kaladay opened this issue Feb 8, 2023 · 0 comments · Fixed by #526
Assignees
Labels
bug Something isn't working

Comments

@kaladay
Copy link
Contributor

kaladay commented Feb 8, 2023

Describe the bug
The more facet having been re-opened multiple times is causing duplicates in the list for every single time it is re-opened.

The modal data is probably not being cleared on close.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a Discovery View with facets that result in the "more..." appearing.
  2. Click on 'more...'.
  3. Close the facet.
  4. Click on the same 'more...' again.
  5. See duplicates.

Expected behavior
The modal displays each facet value only once no matter how many times it is closed and re-opened.

Screenshots
sage_facet_more_problem-2023_02_08

@kaladay kaladay added the bug Something isn't working label Feb 8, 2023
@kaladay kaladay self-assigned this Feb 8, 2023
@kaladay kaladay linked a pull request Feb 8, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant