Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 514: Use Default Field 'df' to prevent syntax problems. #524

Merged
merged 4 commits into from
Feb 7, 2023
Merged

Issue 514: Use Default Field 'df' to prevent syntax problems. #524

merged 4 commits into from
Feb 7, 2023

Conversation

kaladay
Copy link
Contributor

@kaladay kaladay commented Feb 7, 2023

Description

The behavior of manually adding the selected field as a string to the query causes problems. Instead, set the selected field as the Default Field 'df' in the query.

Fixes #514

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually through the UI.
  • Ran unit tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@kaladay
Issue 514: Use Default Field 'df' to prevent syntax problems.
834ded6 
The behavior of manually adding the selected field as a string to the query causes problems.
Instead, set the selected field as the Default Field 'df' in the query.
@kaladay kaladay requested review from jcreel, jeremythuff, a user and rmathew1011 February 7, 2023 22:28
@kaladay kaladay linked an issue Feb 7, 2023 that may be closed by this pull request
Search silently fails when using certain syntax. #514
Open
@coveralls
Copy link

coveralls commented Feb 7, 2023 •
edited
Loading

Coverage Status

Coverage: 45.897% (+0.08%) from 45.813% when pulling 3d4bccc on 514-silent_search_failure into 093cfbf on staging.

@kaladay
Issue 514: Improve logic around isEmpty()/!isEmpty() in query.
3d4bccc 
If the field is not empty but the value is empty, then the wildcard should be used.
The entire "query" string can even be removed.
@kaladay kaladay merged commit 5599f29 into staging Feb 7, 2023
@kaladay kaladay deleted the 514-silent_search_failure branch February 15, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcreel jcreel Awaiting requested review from jcreel

@jeremythuff jeremythuff Awaiting requested review from jeremythuff

@rmathew1011 rmathew1011 Awaiting requested review from rmathew1011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search silently fails when using certain syntax.
2 participants
@kaladay @coveralls