Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 498: Always set facet min count to 1. #521

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Issue 498: Always set facet min count to 1. #521

merged 1 commit into from
Jan 30, 2023

Conversation

kaladay
Copy link
Contributor

@kaladay kaladay commented Jan 30, 2023

Description

This ensures matches of 0 never appear in the facets. The SolrQuery class provides a handy setFacetMinCount() method to easily utilize this functionality.

Fixes #498

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manually.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@kaladay
Issue 498: Always set facet min count to 1.
418ebda 
This ensures matches of 0 never appear in the facets.
The SolrQuery class provides a handy `setFacetMinCount()` method to easily utilize this functionality.
@kaladay kaladay linked an issue Jan 30, 2023 that may be closed by this pull request
Possible regression where facets are showing (0) for valid data. #498
Open
@coveralls
Copy link

Coverage Status

Coverage: 45.844% (-0.03%) from 45.876% when pulling 418ebda on 498-facet_count-avoid_zero into b45e8cc on staging.

@kaladay kaladay merged commit ac12447 into staging Jan 30, 2023
@kaladay kaladay deleted the 498-facet_count-avoid_zero branch February 15, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcreel jcreel Awaiting requested review from jcreel

@jeremythuff jeremythuff Awaiting requested review from jeremythuff

@rmathew1011 rmathew1011 Awaiting requested review from rmathew1011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible regression where facets are showing (0) for valid data.
2 participants
@kaladay @coveralls