Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ID for fields, such as facets and more button, need to be sanitized. #497

Open
kaladay opened this issue Jan 11, 2023 · 0 comments · Fixed by #518
Open

The ID for fields, such as facets and more button, need to be sanitized. #497

kaladay opened this issue Jan 11, 2023 · 0 comments · Fixed by #518
Assignees
Labels
bug Something isn't working

Comments

@kaladay
Copy link
Contributor

kaladay commented Jan 11, 2023

The openMoreFacets() function does not properly sanitize URL, resulting in the following error:

Console log show:

0000000005.js:15697 Error: Syntax error, unrecognized expression: #moreFacetsModal-Content-Type-(SS)

The modal will not open.

The problem is in these spots:

An ID is generated for the modal, that generated ID needs to strip special characters.

@kaladay kaladay added the bug Something isn't working label Jan 11, 2023
@kaladay kaladay self-assigned this Jan 30, 2023
@kaladay kaladay linked a pull request Jan 30, 2023 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant