-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tinymce fix notifications #246
Merged
wwelling
merged 10 commits into
operations-sprint3-staging
from
tinymce-fix-notifications
Jul 8, 2024
Merged
Tinymce fix notifications #246
wwelling
merged 10 commits into
operations-sprint3-staging
from
tinymce-fix-notifications
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required manually adding body to tinymce iframe document
wwelling
force-pushed
the
tinymce-fix-notifications
branch
from
July 5, 2024 14:21
30c9368
to
132a7fe
Compare
tamu-library-components brings in tinymce
kaladay
requested changes
Jul 8, 2024
kaladay
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on the basis that var
is being used to be consistent with existing code.
wwelling
force-pushed
the
tinymce-fix-notifications
branch
2 times, most recently
from
July 8, 2024 15:14
9813421
to
2809f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two things; one the tinymce wysiwyg was not receiving the notification data on update. This is inconsistent with expected use and unknown cause with the tamu-library-component. Adding timeout to digest cycle and reserving the binding with notification data from the scope to the modal resolved this issue.
Until tl-wysiwyg affords consistent binding here is the workaround:
Fixes #245
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test locally with various notifications created and modified.
Checklist: